MD Settings: make chrome://[md-]settings/clearBrowserData URL work

chrome/browser/resources/settings/privacy_page/privacy_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * 'settings-privacy-page' is the settings page containing privacy and
  * security settings.
  */
 Polymer({
@@ skipping 10 matching lines @@
 
     /**
      * The current active route.
      */
     currentRoute: {
       type: Object,
       notify: true,
     },
 
     /** @private */
-    showClearBrowsingDataDialog_: Boolean,
+    showClearBrowsingDataDialog_: {
+      computed: 'computeShowClearBrowsingDataDialog_(currentRoute)',
+      type: Boolean,
+    },
   },
 
   ready: function() {
     this.ContentSettingsTypes = settings.ContentSettingsTypes;
   },
 
+  /** @suppress {missingProperties} */
+  attached: function() {
+    if (this.showClearBrowsingDataDialog_) {
+      settings.main.rendered.then(function() {
+        var dialog = this.$$('settings-clear-browsing-data-dialog').$.dialog;
+        // TODO(dbeam): cast to a CrDialogElement when it compiles.
+        dialog.refit();
+      }.bind(this));
+    }
+  },
+
+  /**
+   * @return {boolean} Whether the Clear Browsing Data dialog should be showing.
+   * @private
+   */
+  computeShowClearBrowsingDataDialog_: function() {
+    var route = this.currentRoute;
+    return route && route.subpage && route.subpage[0] == 'clear-browsing-data';
+  },
+
   /** @private */
   onManageCertificatesTap_: function() {
 <if expr="use_nss_certs">
-    this.$.pages.setSubpageChain(['manage-certificates']);
+    var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages);
+    pages.setSubpageChain(['manage-certificates']);
 </if>
 <if expr="is_win or is_macosx">
     settings.PrivacyPageBrowserProxyImpl.getInstance().
       showManageSSLCertificates();
 </if>
   },
 
   /** @private */
   onSiteSettingsTap_: function() {
-    this.$.pages.setSubpageChain(['site-settings']);
+    var pages = /** @type {!SettingsAnimatedPagesElement} */(this.$.pages);
+    pages.setSubpageChain(['site-settings']);
   },
 
   /** @private */
   onClearBrowsingDataTap_: function() {
     this.showClearBrowsingDataDialog_ = true;

[michaelpg, 2016/06/28 13:58:08]

wat

[michaelpg, 2016/06/28 17:27:59]

I don't understand how this works -- you shouldn't be able to set a computed
property (it's readOnly), so I'm not sure how this triggers the dialog. I think
we actually want to change the route here, now that we're observing the route
itself to open the dialog.

[Dan Beam, 2016/06/28 19:07:52]

Done.

   },
 
   /**
    * @param {!Event} event
    * @private
    */
   onIronOverlayClosed_: function(event) {
     if (Polymer.dom(event).rootTarget.tagName == 'CR-DIALOG')
       this.showClearBrowsingDataDialog_ = false;

[michaelpg, 2016/06/28 13:58:08]

wat

[Dan Beam, 2016/06/28 19:07:52]

Done.

   },
 });