Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/grit/grit/gather/chrome_html.py

Issue 2094193004: Strip comments and whitespace from Javascript resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments, plus rebases. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/grit/grit/flatten_resource_runner_unittest.py ('K') | « tools/grit/grit/format/html_inline.py ('k') | tools/grit/grit/node/include.py » ('j') | tools/grit/grit_rule.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/grit/grit/gather/chrome_html.py
diff --git a/tools/grit/grit/gather/chrome_html.py b/tools/grit/grit/gather/chrome_html.py
index a8f8eb8ddbf8943af4c061ffb96b56eab246baaf..066746514c48238b298249d793405f086204a526 100755
--- a/tools/grit/grit/gather/chrome_html.py
+++ b/tools/grit/grit/gather/chrome_html.py
@@ -347,7 +347,7 @@ class ChromeHtml(interface.GathererBase):
if self.flatten_html_:
self.inlined_text_ = html_inline.InlineToString(
filename,
- self.grd_node,
+ self.grd_node.EvaluateCondition if self.grd_node else None,
allow_external_script = self.allow_external_script_,
preprocess_only = self.preprocess_only_,
rewrite_function=lambda fp, t, d: ProcessImageSets(
« tools/grit/grit/flatten_resource_runner_unittest.py ('K') | « tools/grit/grit/format/html_inline.py ('k') | tools/grit/grit/node/include.py » ('j') | tools/grit/grit_rule.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698