Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: third_party/closure_compiler/compile2.py

Issue 2094193004: Strip comments and whitespace from Javascript resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to comments, plus rebases. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_compiler/compile2.py
diff --git a/third_party/closure_compiler/compile2.py b/third_party/closure_compiler/compile2.py
index df844d129109dc082700ee9e89fe45d6dc534117..c6b47dfc72746d2942f6345aaf7d9ccc236b2b74 100755
--- a/third_party/closure_compiler/compile2.py
+++ b/third_party/closure_compiler/compile2.py
@@ -53,7 +53,7 @@ class Checker(object):
"""Deletes any temp files this class knows about."""
if not self._temp_files:
return
-
+ return
Dan Beam 2016/07/14 17:47:58 remove
self._log_debug("Deleting temp files: %s" % ", ".join(self._temp_files))
for f in self._temp_files:
os.remove(f)
@@ -270,7 +270,7 @@ class Checker(object):
errors = stderr.strip().split("\n\n")
maybe_summary = errors.pop()
- if re.search(".*error.*warning.*typed", maybe_summary):
+ if re.search(".*error.*warning", maybe_summary):
self._log_debug("Summary: %s" % maybe_summary)
else:
# Not a summary. Running the jar failed. Bail.

Powered by Google App Engine
This is Rietveld 408576698