third_party/closure_compiler/compile2.py - Issue 2094193004: Strip comments and whitespace from Javascript resources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/compile2.py

Issue 2094193004: Strip comments and whitespace from Javascript resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to comments, plus rebases. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/closure_compiler/closure_args.gni ('k') | third_party/closure_compiler/compile_js2.gni » ('j') | tools/grit/grit/flatten_resource_runner.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/compile2.py

diff --git a/third_party/closure_compiler/compile2.py b/third_party/closure_compiler/compile2.py

index df844d129109dc082700ee9e89fe45d6dc534117..c6b47dfc72746d2942f6345aaf7d9ccc236b2b74 100755

--- a/third_party/closure_compiler/compile2.py

+++ b/third_party/closure_compiler/compile2.py

@@ -53,7 +53,7 @@ class Checker(object):

"""Deletes any temp files this class knows about."""

if not self._temp_files:

return

+ return

Dan Beam 2016/07/14 17:47:58 remove

self._log_debug("Deleting temp files: %s" % ", ".join(self._temp_files))

for f in self._temp_files:

os.remove(f)

@@ -270,7 +270,7 @@ class Checker(object):

errors = stderr.strip().split("\n\n")

maybe_summary = errors.pop()

- if re.search(".*error.*warning.*typed", maybe_summary):

+ if re.search(".*error.*warning", maybe_summary):

self._log_debug("Summary: %s" % maybe_summary)

else:

# Not a summary. Running the jar failed. Bail.