Strip comments and whitespace from Javascript resources

chrome/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chrome_build.gni")
 import("//build/config/crypto.gni")
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//chrome/common/features.gni")
 import("//media/media_options.gni")
@@ skipping 1003 matching lines @@
       "//chrome/common:constants",
     ]
     if (enable_configuration_policy) {
       deps += [ "//chrome/browser/policy:path_parser" ]
     }
   }
 }
 
 # GYP version: chrome/chrome_resources.gyp:chrome_resources
 # (generate_browser_resources action)
-grit("resources") {
+strip_and_grit("resources") {
+  js_resource_files = [

[Lei Zhang, 2016/06/29 22:51:32]

So where does this list come from? How do we maintain it going forward?

[aberent, 2016/07/14 15:41:36]

I got it originally by running grit buildinfo, but it will need to be maintained
manually. This is no different from any other source files; our GN files list
all our C++ and Java source and header files (and, in fact, for Java, as part of
the GN conversion, we removed the ability to find source files automatically).

There is a possible issue that we currently have no automatic check that this
list is complete, but this also true of C++ header files.

[Lei Zhang, 2016/07/15 00:13:09]

The question of how to maintain this list going forward still stands. What's the
process for developers to follow here?

Also, what about chrome/browser/resources/certificate_viewer.js as an example,
where in the .grd file, it's behind an <if> condition? Do we just say meh and
process it anyway?

+    "//chrome/browser/resources/about_nacl.js",
+    "//chrome/browser/resources/about_sys/about_sys.js",
+    "//chrome/browser/resources/certificate_viewer.js",
+    "//chrome/browser/resources/components.js",
+    "//chrome/browser/resources/copresence.js",
+    "//chrome/browser/resources/device_log_ui/device_log_ui.js",
+    "//chrome/browser/resources/domain_reliability_internals.js",
+    "//chrome/browser/resources/engagement/site_engagement.js",
+    "//chrome/browser/resources/gaia_auth/channel.js",
+    "//chrome/browser/resources/gaia_auth/saml_injected.js",
+    "//chrome/browser/resources/gaia_auth_host/authenticator.js",
+    "//chrome/browser/resources/gaia_auth_host/gaia_auth_host.js",
+    "//chrome/browser/resources/gaia_auth_host/post_message_channel.js",
+    "//chrome/browser/resources/gaia_auth_host/saml_handler.js",
+    "//chrome/browser/resources/gaia_auth_host/webview_saml_injected.js",
+    "//chrome/browser/resources/help/channel_change_page.js",
+    "//chrome/browser/resources/help/help.js",
+    "//chrome/browser/resources/help/help_page.js",
+    "//chrome/browser/resources/history/history.js",
+    "//chrome/browser/resources/history/history_focus_manager.js",
+    "//chrome/browser/resources/history/other_devices.js",
+    "//chrome/browser/resources/identity_internals.js",
+    "//chrome/browser/resources/inline_login/inline_login.js",
+    "//chrome/browser/resources/inspect/inspect.js",
+    "//chrome/browser/resources/instant/instant.js",
+    "//chrome/browser/resources/local_ntp/instant_iframe_validation.js",
+    "//chrome/browser/resources/local_ntp/local_ntp.js",
+    "//chrome/browser/resources/local_ntp/local_ntp_util.js",
+    "//chrome/browser/resources/local_ntp/most_visited_single.js",
+    "//chrome/browser/resources/local_ntp/most_visited_thumbnail.js",
+    "//chrome/browser/resources/local_ntp/most_visited_title.js",
+    "//chrome/browser/resources/local_ntp/most_visited_util.js",
+    "//chrome/browser/resources/local_state/local_state.js",
+    "//chrome/browser/resources/md_downloads/action_service.js",
+    "//chrome/browser/resources/md_downloads/constants.js",
+    "//chrome/browser/resources/md_downloads/downloads.js",
+    "//chrome/browser/resources/md_downloads/item.js",
+    "//chrome/browser/resources/md_downloads/manager.js",
+    "//chrome/browser/resources/md_downloads/toolbar.js",
+    "//chrome/browser/resources/md_feedback/feedback_container.js",
+    "//chrome/browser/resources/md_history/app.js",
+    "//chrome/browser/resources/md_history/browser_service.js",
+    "//chrome/browser/resources/md_history/constants.js",
+    "//chrome/browser/resources/md_history/grouped_list.js",
+    "//chrome/browser/resources/md_history/history.js",
+    "//chrome/browser/resources/md_history/history_item.js",
+    "//chrome/browser/resources/md_history/history_list.js",
+    "//chrome/browser/resources/md_history/history_toolbar.js",
+    "//chrome/browser/resources/md_history/searched_label.js",
+    "//chrome/browser/resources/md_history/side_bar.js",
+    "//chrome/browser/resources/md_history/synced_device_card.js",
+    "//chrome/browser/resources/md_history/synced_device_manager.js",
+    "//chrome/browser/resources/md_user_manager/control_bar.js",
+    "//chrome/browser/resources/md_user_manager/create_profile.js",
+    "//chrome/browser/resources/md_user_manager/error_dialog.js",
+    "//chrome/browser/resources/md_user_manager/import_supervised_user.js",
+    "//chrome/browser/resources/md_user_manager/profile_browser_proxy.js",
+    "//chrome/browser/resources/md_user_manager/supervised_user_create_confirm.js",
+    "//chrome/browser/resources/md_user_manager/supervised_user_learn_more.js",
+    "//chrome/browser/resources/md_user_manager/user_manager.js",
+    "//chrome/browser/resources/md_user_manager/user_manager_dialog.js",
+    "//chrome/browser/resources/md_user_manager/user_manager_pages.js",
+    "//chrome/browser/resources/md_user_manager/user_manager_tutorial.js",
+    "//chrome/browser/resources/ntp4/apps_page.js",
+    "//chrome/browser/resources/ntp4/dot_list.js",
+    "//chrome/browser/resources/ntp4/logging.js",
+    "//chrome/browser/resources/ntp4/nav_dot.js",
+    "//chrome/browser/resources/ntp4/new_tab.js",
+    "//chrome/browser/resources/ntp4/page_list_view.js",
+    "//chrome/browser/resources/ntp4/page_switcher.js",
+    "//chrome/browser/resources/ntp4/tile_page.js",
+    "//chrome/browser/resources/ntp4/trash.js",
+    "//chrome/browser/resources/omnibox/omnibox.js",
+    "//chrome/browser/resources/policy.js",
+    "//chrome/browser/resources/predictors/autocomplete_action_predictor.js",
+    "//chrome/browser/resources/predictors/predictors.js",
+    "//chrome/browser/resources/predictors/resource_prefetch_predictor.js",
+    "//chrome/browser/resources/profile_signin_confirmation.js",
+    "//chrome/browser/resources/profiler/profiler.js",
+    "//chrome/browser/resources/supervised_user_internals.js",
+    "//chrome/browser/resources/sync_confirmation/sync_confirmation.js",
+    "//chrome/browser/resources/synthetic_middleclick.js",
+    "//chrome/browser/resources/uber/uber.js",
+    "//chrome/browser/resources/uber/uber_frame.js",
+    "//chrome/browser/resources/uber/uber_page_manager_observer.js",
+    "//chrome/browser/resources/uber/uber_utils.js",
+    "//chrome/browser/resources/user_actions/user_actions.js",
+    "//chrome/browser/resources/user_manager/control_bar.js",
+    "//chrome/browser/resources/user_manager/user_manager.js",
+    "//chrome/browser/resources/user_manager/user_manager_tutorial.js",
+    "//ui/login/account_picker/screen_account_picker.js",
+    "//ui/login/account_picker/user_pod_row.js",
+    "//ui/login/bubble.js",
+    "//ui/login/display_manager.js",
+    "//ui/login/login_ui_tools.js",
+    "//ui/login/resource_loader.js",
+    "//ui/login/screen.js",
+    "//ui/webui/resources/js/action_link.js",
+    "//ui/webui/resources/js/assert.js",
+    "//ui/webui/resources/js/cr.js",
+    "//ui/webui/resources/js/cr/event_target.js",
+    "//ui/webui/resources/js/cr/ui.js",
+    "//ui/webui/resources/js/cr/ui/bubble.js",
+    "//ui/webui/resources/js/cr/ui/card_slider.js",
+    "//ui/webui/resources/js/cr/ui/context_menu_button.js",
+    "//ui/webui/resources/js/cr/ui/context_menu_handler.js",
+    "//ui/webui/resources/js/cr/ui/drag_wrapper.js",
+    "//ui/webui/resources/js/cr/ui/expandable_bubble.js",
+    "//ui/webui/resources/js/cr/ui/focus_manager.js",
+    "//ui/webui/resources/js/cr/ui/menu.js",
+    "//ui/webui/resources/js/cr/ui/menu_button.js",
+    "//ui/webui/resources/js/cr/ui/menu_item.js",
+    "//ui/webui/resources/js/cr/ui/position_util.js",
+    "//ui/webui/resources/js/cr/ui/touch_handler.js",
+    "//ui/webui/resources/js/event_tracker.js",
+    "//ui/webui/resources/js/util.js",
+  ]
+
   source = "browser_resources.grd"
   defines = chrome_grit_defines
   output_dir = "$root_gen_dir/chrome"
   outputs = [
     "grit/browser_resources.h",
     "browser_resources.pak",
   ]
 
   grit_flags = [
     "-E",
@@ skipping 339 matching lines @@
   # linking all of the test support.
   source_set("pepper_cdm_test_constants") {
     testonly = true
     visibility = [ "//chrome/*" ]
     sources = [
       "media/pepper_cdm_test_constants.cc",
       "media/pepper_cdm_test_constants.h",
     ]
   }
 }