ui/views/controls/menu/menu_runner_cocoa_unittest.mm - Issue 2094193002: Deflake Mac views_unittest's MenuRunnerCocoaTest.RunMenuAndCancel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_runner_cocoa_unittest.mm

Issue 2094193002: Deflake Mac views_unittest's MenuRunnerCocoaTest.RunMenuAndCancel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Lint Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/menu/menu_runner_cocoa_unittest.mm

diff --git a/ui/views/controls/menu/menu_runner_cocoa_unittest.mm b/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

index 310803d6f84a5dc68c3df85d805e6cc12ec9850c..09449d24c86170d83f58391c7cbc0585db523479 100644

--- a/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

+++ b/ui/views/controls/menu/menu_runner_cocoa_unittest.mm

@@ -168,7 +168,7 @@ class MenuRunnerCocoaTest : public ViewsTestBase {

DISALLOW_COPY_AND_ASSIGN(MenuRunnerCocoaTest);

};

-TEST_F(MenuRunnerCocoaTest, DISABLED_RunMenuAndCancel) {

+TEST_F(MenuRunnerCocoaTest, RunMenuAndCancel) {

base::TimeTicks min_time = ui::EventTimeForNow();

MenuRunner::RunResult result = RunMenu(base::Bind(

« no previous file with comments | « ui/events/test/event_generator.cc ('k') | ui/views/controls/menu/menu_runner_impl_cocoa.mm » ('j') | no next file with comments »