Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Side by Side Diff: tools/perf/benchmarks/system_health.py

Issue 2094143005: [perf] Enable non-verbose logging in memory system health benchmarks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: System Health only Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from telemetry import benchmark 8 from telemetry import benchmark
9 from telemetry.timeline import tracing_category_filter 9 from telemetry.timeline import tracing_category_filter
10 from telemetry.web_perf import timeline_based_measurement 10 from telemetry.web_perf import timeline_based_measurement
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 return 'system_health.key_mobile_sites' 57 return 'system_health.key_mobile_sites'
58 58
59 59
60 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark): 60 class _MemorySystemHealthBenchmark(perf_benchmark.PerfBenchmark):
61 """Chrome Memory System Health Benchmark. 61 """Chrome Memory System Health Benchmark.
62 62
63 https://goo.gl/Jek2NL. 63 https://goo.gl/Jek2NL.
64 """ 64 """
65 65
66 def SetExtraBrowserOptions(self, options): 66 def SetExtraBrowserOptions(self, options):
67 # TODO(petrcermak): Remove this and switch to log-on-retry
68 # (http://crbug.com/623058).
69 options.logging_verbosity = options.NON_VERBOSE_LOGGING
67 options.AppendExtraBrowserArgs([ 70 options.AppendExtraBrowserArgs([
68 # TODO(perezju): Temporary workaround to disable periodic memory dumps. 71 # TODO(perezju): Temporary workaround to disable periodic memory dumps.
69 # See: http://crbug.com/513692 72 # See: http://crbug.com/513692
70 '--enable-memory-benchmarking', 73 '--enable-memory-benchmarking',
71 ]) 74 ])
72 75
73 def CreateTimelineBasedMeasurementOptions(self): 76 def CreateTimelineBasedMeasurementOptions(self):
74 options = timeline_based_measurement.Options( 77 options = timeline_based_measurement.Options(
75 tracing_category_filter.TracingCategoryFilter( 78 tracing_category_filter.TracingCategoryFilter(
76 '-*,disabled-by-default-memory-infra')) 79 '-*,disabled-by-default-memory-infra'))
(...skipping 25 matching lines...) Expand all
102 """Mobile Chrome Memory System Health Benchmark.""" 105 """Mobile Chrome Memory System Health Benchmark."""
103 page_set = page_sets.MobileMemorySystemHealthStorySet 106 page_set = page_sets.MobileMemorySystemHealthStorySet
104 107
105 @classmethod 108 @classmethod
106 def ShouldDisable(cls, possible_browser): 109 def ShouldDisable(cls, possible_browser):
107 # http://crbug.com/612144 (reference on Nexus 5X). 110 # http://crbug.com/612144 (reference on Nexus 5X).
108 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or ( 111 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' or (
109 possible_browser.browser_type == 'reference' and 112 possible_browser.browser_type == 'reference' and
110 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X') 113 possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X')
111 114
115
112 @benchmark.Enabled('android-webview') 116 @benchmark.Enabled('android-webview')
113 class WebviewStartupSystemHealthBenchmark(perf_benchmark.PerfBenchmark): 117 class WebviewStartupSystemHealthBenchmark(perf_benchmark.PerfBenchmark):
114 """Webview startup time benchmark 118 """Webview startup time benchmark
115 119
116 Benchmark that measures how long WebView takes to start up 120 Benchmark that measures how long WebView takes to start up
117 and load a blank page. Since thie metric only requires the trace 121 and load a blank page. Since thie metric only requires the trace
118 markers recorded in atrace, Chrome tracing is not enabled for this 122 markers recorded in atrace, Chrome tracing is not enabled for this
119 benchmark. 123 benchmark.
120 """ 124 """
121 page_set = page_sets.BlankPageSet 125 page_set = page_sets.BlankPageSet
122 126
123 def CreateTimelineBasedMeasurementOptions(self): 127 def CreateTimelineBasedMeasurementOptions(self):
124 options = timeline_based_measurement.Options() 128 options = timeline_based_measurement.Options()
125 options.SetTimelineBasedMetric('webviewStartupMetric') 129 options.SetTimelineBasedMetric('webviewStartupMetric')
126 options.config.enable_atrace_trace = True 130 options.config.enable_atrace_trace = True
127 options.config.enable_chrome_trace = False 131 options.config.enable_chrome_trace = False
128 options.config.atrace_config.app_name = 'org.chromium.webview_shell' 132 options.config.atrace_config.app_name = 'org.chromium.webview_shell'
129 return options 133 return options
130 134
131 @classmethod 135 @classmethod
132 def ShouldTearDownStateAfterEachStoryRun(cls): 136 def ShouldTearDownStateAfterEachStoryRun(cls):
133 return True 137 return True
134 138
135 @classmethod 139 @classmethod
136 def Name(cls): 140 def Name(cls):
137 return 'system_health.webview_startup' 141 return 'system_health.webview_startup'
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698