Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2094143003: X87: [wasm] Support for memory size relocation for asm-wasm. (Closed)

Created:
4 years, 5 months ago by zhengxing.li
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Support for memory size relocation for asm-wasm. port c5e3c9bf5661c519e36e34493b5625f6c5614c36 (r37011) original commit message: Only Intel needed changes, arm and mips work as expected. BUG= Committed: https://crrev.com/21c4be4d28c3106b43da4db6c2ce46ba532c6086 Cr-Commit-Position: refs/heads/master@{#37267}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/x87/macro-assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 5 months ago (2016-06-27 03:44:45 UTC) #2
Weiliang
lgtm
4 years, 5 months ago (2016-06-27 03:55:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2094143003/1
4 years, 5 months ago (2016-06-27 04:01:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-27 04:22:52 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 04:25:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21c4be4d28c3106b43da4db6c2ce46ba532c6086
Cr-Commit-Position: refs/heads/master@{#37267}

Powered by Google App Engine
This is Rietveld 408576698