third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp - Issue 2094143002: Avoid snapshotting ContextLifecycleObservers when iterating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

Issue 2094143002: Avoid snapshotting ContextLifecycleObservers when iterating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove IterationScope, indirection not needed Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/DOMWindowLifecycleNotifier.cpp ('k') | third_party/WebKit/Source/core/frame/LocalFrameLifecycleNotifier.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

index 455a2f3e40120b7d65947dcafbfb5b4292885d22..f6573e38431fe5c1f24825e2a4c473edb2563d4e 100644

--- a/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp

@@ -171,14 +171,12 @@ private:

m_disposalAllowed = false;

m_window->postMessageTimerFired(this);

dispose();

+ // Oilpan optimization: unregister as an observer right away.

+ clearContext();

}

void dispose()

{

- // Oilpan optimization: unregister as an observer right away.

- clearContext();

- // Will destroy this object, now or after the next GC depending

- // on whether Oilpan is disabled or not.

m_window->removePostMessageTimer(this);

}