third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp - Issue 2094143002: Avoid snapshotting ContextLifecycleObservers when iterating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

Issue 2094143002: Avoid snapshotting ContextLifecycleObservers when iterating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: msvc compile fix.. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/LocalFrameLifecycleNotifier.cpp ('k') | third_party/WebKit/Source/platform/LifecycleNotifier.h » ('j') | third_party/WebKit/Source/platform/LifecycleNotifier.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

diff --git a/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp b/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

index 5a6db288139154bf8776f1ed6e4788cff857a99b..f7037c774b881ff6f8ec30b21b0f63252c4252e9 100644

--- a/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

+++ b/third_party/WebKit/Source/core/page/PageLifecycleNotifier.cpp

@@ -32,15 +32,15 @@ namespace blink {

void PageLifecycleNotifier::notifyPageVisibilityChanged()

{

- TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);

- for (PageLifecycleObserver* observer : m_observers)

+ IterationScope scope(this);

+ for (PageLifecycleObserver* observer : scope.observers())

observer->pageVisibilityChanged();

}

void PageLifecycleNotifier::notifyDidCommitLoad(LocalFrame* frame)

{

- TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);

- for (PageLifecycleObserver* observer : m_observers)

+ IterationScope scope(this);

+ for (PageLifecycleObserver* observer : scope.observers())

observer->didCommitLoad(frame);

}