Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: third_party/WebKit/Source/core/frame/DOMWindowLifecycleNotifier.cpp

Issue 2094143002: Avoid snapshotting ContextLifecycleObservers when iterating. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove IterationScope, indirection not needed Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All Rights Reserved. 2 * Copyright (C) 2013 Google Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 13 matching lines...) Expand all
24 */ 24 */
25 25
26 #include "core/frame/DOMWindowLifecycleNotifier.h" 26 #include "core/frame/DOMWindowLifecycleNotifier.h"
27 27
28 #include "core/frame/DOMWindowLifecycleObserver.h" 28 #include "core/frame/DOMWindowLifecycleObserver.h"
29 29
30 namespace blink { 30 namespace blink {
31 31
32 void DOMWindowLifecycleNotifier::notifyAddEventListener(LocalDOMWindow* window, const AtomicString& eventType) 32 void DOMWindowLifecycleNotifier::notifyAddEventListener(LocalDOMWindow* window, const AtomicString& eventType)
33 { 33 {
34 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll); 34 TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);
35 for (DOMWindowLifecycleObserver* observer : m_observers) 35 for (DOMWindowLifecycleObserver* observer : m_observers)
36 observer->didAddEventListener(window, eventType); 36 observer->didAddEventListener(window, eventType);
37 } 37 }
38 38
39 void DOMWindowLifecycleNotifier::notifyRemoveEventListener(LocalDOMWindow* windo w, const AtomicString& eventType) 39 void DOMWindowLifecycleNotifier::notifyRemoveEventListener(LocalDOMWindow* windo w, const AtomicString& eventType)
40 { 40 {
41 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll); 41 TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);
42 for (DOMWindowLifecycleObserver* observer : m_observers) 42 for (DOMWindowLifecycleObserver* observer : m_observers)
43 observer->didRemoveEventListener(window, eventType); 43 observer->didRemoveEventListener(window, eventType);
44 } 44 }
45 45
46 void DOMWindowLifecycleNotifier::notifyRemoveAllEventListeners(LocalDOMWindow* w indow) 46 void DOMWindowLifecycleNotifier::notifyRemoveAllEventListeners(LocalDOMWindow* w indow)
47 { 47 {
48 TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll); 48 TemporaryChange<IterationState> scope(m_iterationState, AllowingNone);
49 for (DOMWindowLifecycleObserver* observer : m_observers) 49 for (DOMWindowLifecycleObserver* observer : m_observers)
50 observer->didRemoveAllEventListeners(window); 50 observer->didRemoveAllEventListeners(window);
51 } 51 }
52 52
53 } // namespace blink 53 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698