Oilpan: Remove unused destructor from non-finalized SharedWorkerPerformance.

Oilpan: Remove unused destructor from non-finalized SharedWorkerPerformance.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169915

[haraken, 2014-03-24 11:20:42]

The change looks OK, but what's the problem this CL is going to solve?

[zerny-chromium, 2014-03-24 12:10:21]

The rule is that if a class has a destructor it must be derived from a
GC-finanalized class. Otherwise the dtor is dead code (which is not always
obvious). In this case the dtor is not needed and so I removed it instead
of making SharedWorkerPerformance GarbageCollectedFinalized.

This "error" was caught by the clang plugin.


On Mon, Mar 24, 2014 at 12:20 PM, <haraken@chromium.org> wrote:

> The change looks OK, but what's the problem this CL is going to solve?
>
>
> https://codereview.chromium.org/209413007/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[haraken, 2014-03-24 12:11:56]

> The rule is that if a class has a destructor it must be derived from a
> GC-finanalized class. Otherwise the dtor is dead code (which is not always
> obvious). In this case the dtor is not needed and so I removed it instead
> of making SharedWorkerPerformance GarbageCollectedFinalized.

Makes sense. LGTM.

[zerny-chromium, 2014-03-24 12:42:37]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-24 12:42:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/209413007/1

[commit-bot: I haz the power, 2014-03-24 13:46:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 13:46:52]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[zerny-chromium, 2014-03-24 14:08:20]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:08:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/209413007/1

[commit-bot: I haz the power, 2014-03-24 14:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:48:00]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[zerny-chromium, 2014-03-24 14:56:02]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:56:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/209413007/1

[commit-bot: I haz the power, 2014-03-24 14:57:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-24 14:57:33]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[zerny-chromium, 2014-03-25 06:50:36]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-25 06:50:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/209413007/1

[commit-bot: I haz the power, 2014-03-25 06:53:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-25 06:53:22]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[zerny-chromium, 2014-03-25 06:58:35]

The CQ bit was checked by zerny@chromium.org

[commit-bot: I haz the power, 2014-03-25 06:58:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/zerny@chromium.org/209413007/1

[commit-bot: I haz the power, 2014-03-25 06:59:07]

Change committed as 169915