Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2093993002: Make bucket names explicit in cq.cfg. (Closed)

Created:
4 years, 5 months ago by tandrii(chromium)
Modified:
4 years, 5 months ago
Reviewers:
Michael Achenbach
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make bucket names explicit in cq.cfg. Don't assume bucket name to start with 'master.'. NOTRY=True BUG=chromium:617627 R=machenbach@chromium.org Committed: https://crrev.com/44ca872385198d4c48cdc8a315d5aa129b69d5d7 Cr-Commit-Position: refs/heads/master@{#37258}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/config/cq.cfg View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
tandrii(chromium)
4 years, 5 months ago (2016-06-24 18:15:29 UTC) #1
Michael Achenbach
lgtm
4 years, 5 months ago (2016-06-24 20:10:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093993002/1
4 years, 5 months ago (2016-06-24 20:11:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-24 20:13:47 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-06-24 20:14:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44ca872385198d4c48cdc8a315d5aa129b69d5d7
Cr-Commit-Position: refs/heads/master@{#37258}

Powered by Google App Engine
This is Rietveld 408576698