Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2093983002: scheduler: Tell v8 about the current RAIL mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.h ('k') | components/scheduler/renderer/renderer_scheduler_impl_unittest.cc » ('j') | content/renderer/render_thread_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl.cc b/components/scheduler/renderer/renderer_scheduler_impl.cc
index b9e74d0dd11f45af3ed343fa829aa9f3fecf1137..cb911cc72891b91448484599eee6db69be8fc7d5 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl.cc
@@ -132,7 +132,8 @@ RendererSchedulerImpl::MainThreadOnly::MainThreadOnly(
has_visible_render_widget_with_touch_handler(false),
begin_frame_not_expected_soon(false),
expensive_task_blocking_allowed(true),
- in_idle_period_for_testing(false) {}
+ in_idle_period_for_testing(false),
+ isolate(nullptr) {}
RendererSchedulerImpl::MainThreadOnly::~MainThreadOnly() {}
@@ -731,9 +732,16 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
Policy new_policy;
ExpensiveTaskPolicy expensive_task_policy = ExpensiveTaskPolicy::RUN;
+
+ if (MainThreadOnly().begin_frame_not_expected_soon)
+ new_policy.rail_mode = v8::PERFORMANCE_DEFAULT;
+ else
+ new_policy.rail_mode = v8::PERFORMANCE_ANIMATION;
+
switch (use_case) {
case UseCase::COMPOSITOR_GESTURE:
if (touchstart_expected_soon) {
+ new_policy.rail_mode = v8::PERFORMANCE_RESPONSE;
expensive_task_policy = ExpensiveTaskPolicy::BLOCK;
new_policy.compositor_queue_policy.priority = TaskQueue::HIGH_PRIORITY;
} else {
@@ -751,8 +759,10 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
main_thread_compositing_is_fast ? TaskQueue::HIGH_PRIORITY
: TaskQueue::NORMAL_PRIORITY;
if (touchstart_expected_soon) {
+ new_policy.rail_mode = v8::PERFORMANCE_RESPONSE;
expensive_task_policy = ExpensiveTaskPolicy::BLOCK;
} else {
+ new_policy.rail_mode = v8::PERFORMANCE_ANIMATION;
expensive_task_policy = ExpensiveTaskPolicy::THROTTLE;
}
break;
@@ -762,6 +772,7 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
// about which things we should be prioritizing, so we don't attempt to
// block expensive tasks because we don't know whether they were integral
// to the page's functionality or not.
+ new_policy.rail_mode = v8::PERFORMANCE_ANIMATION;
new_policy.compositor_queue_policy.priority =
main_thread_compositing_is_fast ? TaskQueue::HIGH_PRIORITY
: TaskQueue::NORMAL_PRIORITY;
@@ -774,13 +785,16 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
// handling over other tasks.
new_policy.compositor_queue_policy.priority = TaskQueue::HIGH_PRIORITY;
if (touchstart_expected_soon) {
+ new_policy.rail_mode = v8::PERFORMANCE_RESPONSE;
expensive_task_policy = ExpensiveTaskPolicy::BLOCK;
} else {
+ new_policy.rail_mode = v8::PERFORMANCE_ANIMATION;
expensive_task_policy = ExpensiveTaskPolicy::THROTTLE;
}
break;
case UseCase::TOUCHSTART:
+ new_policy.rail_mode = v8::PERFORMANCE_RESPONSE;
new_policy.compositor_queue_policy.priority = TaskQueue::HIGH_PRIORITY;
new_policy.loading_queue_policy.is_enabled = false;
new_policy.timer_queue_policy.is_enabled = false;
@@ -793,11 +807,13 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
// driven gesture.
if (touchstart_expected_soon &&
AnyThread().last_gesture_was_compositor_driven) {
+ new_policy.rail_mode = v8::PERFORMANCE_RESPONSE;
expensive_task_policy = ExpensiveTaskPolicy::BLOCK;
}
break;
case UseCase::LOADING:
+ new_policy.rail_mode = v8::PERFORMANCE_LOAD;
new_policy.loading_queue_policy.priority = TaskQueue::HIGH_PRIORITY;
new_policy.default_queue_policy.priority = TaskQueue::HIGH_PRIORITY;
break;
@@ -806,6 +822,9 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
NOTREACHED();
}
+ if (MainThreadOnly().renderer_hidden)
+ new_policy.rail_mode = v8::PERFORMANCE_IDLE;
+
if (expensive_task_policy == ExpensiveTaskPolicy::BLOCK &&
(!MainThreadOnly().expensive_task_blocking_allowed ||
!MainThreadOnly().have_seen_a_begin_main_frame ||
@@ -856,6 +875,8 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
this, AsValueLocked(now));
TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "use_case",
use_case);
+ TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "rail_mode",
+ new_policy.rail_mode);
TRACE_COUNTER1(TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"),
"touchstart_expected_soon",
MainThreadOnly().touchstart_expected_soon);
@@ -898,6 +919,10 @@ void RendererSchedulerImpl::UpdatePolicyLocked(UpdateType update_type) {
ApplyTaskQueuePolicy(helper_.DefaultTaskRunner().get(),
MainThreadOnly().current_policy.default_queue_policy,
new_policy.default_queue_policy);
+ if (MainThreadOnly().isolate &&
+ new_policy.rail_mode != MainThreadOnly().current_policy.rail_mode) {
+ MainThreadOnly().isolate->SetRAILMode(new_policy.rail_mode);
+ }
DCHECK(compositor_task_runner_->IsQueueEnabled());
MainThreadOnly().current_policy = new_policy;
@@ -1094,6 +1119,8 @@ RendererSchedulerImpl::AsValueLocked(base::TimeTicks optional_now) const {
MainThreadOnly().has_visible_render_widget_with_touch_handler);
state->SetString("current_use_case",
UseCaseToString(MainThreadOnly().current_use_case));
+ state->SetString("rail_mode",
+ RAILModeToString(MainThreadOnly().current_policy.rail_mode));
state->SetBoolean("expensive_task_blocking_allowed",
MainThreadOnly().expensive_task_blocking_allowed);
state->SetBoolean("loading_tasks_seem_expensive",
@@ -1273,6 +1300,10 @@ void RendererSchedulerImpl::SetTopLevelBlameContext(
idle_helper_.IdleTaskRunner()->SetBlameContext(blame_context);
}
+void RendererSchedulerImpl::SetMainThreadIsolate(v8::Isolate* isolate) {
+ MainThreadOnly().isolate = isolate;
+}
+
void RendererSchedulerImpl::RegisterTimeDomain(TimeDomain* time_domain) {
helper_.RegisterTimeDomain(time_domain);
}
@@ -1291,20 +1322,20 @@ base::TickClock* RendererSchedulerImpl::tick_clock() const {
void RendererSchedulerImpl::AddWebViewScheduler(
WebViewSchedulerImpl* web_view_scheduler) {
- MainThreadOnly().web_view_schedulers_.insert(web_view_scheduler);
+ MainThreadOnly().web_view_schedulers.insert(web_view_scheduler);
}
void RendererSchedulerImpl::RemoveWebViewScheduler(
WebViewSchedulerImpl* web_view_scheduler) {
- DCHECK(MainThreadOnly().web_view_schedulers_.find(web_view_scheduler) !=
- MainThreadOnly().web_view_schedulers_.end());
- MainThreadOnly().web_view_schedulers_.erase(web_view_scheduler);
+ DCHECK(MainThreadOnly().web_view_schedulers.find(web_view_scheduler) !=
+ MainThreadOnly().web_view_schedulers.end());
+ MainThreadOnly().web_view_schedulers.erase(web_view_scheduler);
}
void RendererSchedulerImpl::BroadcastConsoleWarning(
const std::string& message) {
helper_.CheckOnValidThread();
- for (auto& web_view_scheduler : MainThreadOnly().web_view_schedulers_)
+ for (auto& web_view_scheduler : MainThreadOnly().web_view_schedulers)
web_view_scheduler->AddConsoleWarning(message);
}
@@ -1348,4 +1379,46 @@ void RendererSchedulerImpl::OnTriedToExecuteBlockedTask(
}
}
+// static
+const char* RendererSchedulerImpl::UseCaseToString(UseCase use_case) {
+ switch (use_case) {
+ case UseCase::NONE:
+ return "none";
+ case UseCase::COMPOSITOR_GESTURE:
+ return "compositor_gesture";
+ case UseCase::MAIN_THREAD_CUSTOM_INPUT_HANDLING:
+ return "main_thread_custom_input_handling";
+ case UseCase::SYNCHRONIZED_GESTURE:
+ return "synchronized_gesture";
+ case UseCase::TOUCHSTART:
+ return "touchstart";
+ case UseCase::LOADING:
+ return "loading";
+ case UseCase::MAIN_THREAD_GESTURE:
+ return "main_thread_gesture";
+ default:
+ NOTREACHED();
+ return nullptr;
+ }
+}
+
+// static
+const char* RendererSchedulerImpl::RAILModeToString(v8::RAILMode rail_mode) {
+ switch (rail_mode) {
+ case v8::PERFORMANCE_DEFAULT:
+ return "default";
+ case v8::PERFORMANCE_RESPONSE:
+ return "response";
+ case v8::PERFORMANCE_ANIMATION:
+ return "animation";
+ case v8::PERFORMANCE_IDLE:
+ return "idle";
+ case v8::PERFORMANCE_LOAD:
+ return "load";
+ default:
+ NOTREACHED();
+ return nullptr;
+ }
+}
+
} // namespace scheduler
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.h ('k') | components/scheduler/renderer/renderer_scheduler_impl_unittest.cc » ('j') | content/renderer/render_thread_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698