Ignore alpha value in extension-specified badge bg color.

Ignore alpha value in extension-specified badge bg color.
(Force full opacity.)

BUG=619499
Committed: https://crrev.com/b16eadaef85aa0128bf4f74fb96270f0a2479b78
Cr-Commit-Position: refs/heads/master@{#402198}

[Evan Stade, 2016-06-24 18:06:42]

estade@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Evan Stade, 2016-06-24 18:06:43]

see bug for alternative approaches

[Devlin, 2016-06-24 20:59:58]

On 2016/06/24 18:06:43, Evan Stade wrote:
> see bug for alternative approaches

Can you post a screenshot of what this looks like?

[Evan Stade, 2016-06-24 21:32:46]

On 2016/06/24 20:59:58, Devlin wrote:
> On 2016/06/24 18:06:43, Evan Stade wrote:
> > see bug for alternative approaches
> 
> Can you post a screenshot of what this looks like?

screenshot here: https://screenshot.googleplex.com/Gyrxug3VgB7.png

the extension author would likely want to change the color of the badge because
it's too bright green now, as was discussed in crbug.com/598440

[Devlin, 2016-06-24 23:01:15]

lgtm

https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extension...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right):

https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extension...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:175:
background_color = SkColorSetA(background_color, SK_AlphaOPAQUE);
Let's add a comment here saying why we ignore alpha.  Otherwise crbug.com/700xxx
is going to have us fix it, and we'll think it's an easy one line fix to change
it back. :)

[Evan Stade, 2016-06-27 15:30:03]

https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extension...
File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right):

https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extension...
chrome/browser/ui/extensions/icon_with_badge_image_source.cc:175:
background_color = SkColorSetA(background_color, SK_AlphaOPAQUE);
On 2016/06/24 23:01:15, Devlin wrote:
> Let's add a comment here saying why we ignore alpha.  Otherwise
crbug.com/700xxx
> is going to have us fix it, and we'll think it's an easy one line fix to
change
> it back. :)

good idea, done.

[Evan Stade, 2016-06-27 15:30:30]

1

[Evan Stade, 2016-06-27 15:30:43]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-06-27 15:30:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/2093973002/#ps20001
(title: "commentary")

[commit-bot: I haz the power, 2016-06-27 15:32:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:34:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-27 16:36:24]

Description was changed from

==========
Ignore alpha value in extension-specified badge bg color.
(Force full opacity.)

BUG=619499
==========

to

==========
Ignore alpha value in extension-specified badge bg color.
(Force full opacity.)

BUG=619499

Committed: https://crrev.com/b16eadaef85aa0128bf4f74fb96270f0a2479b78
Cr-Commit-Position: refs/heads/master@{#402198}
==========

[commit-bot: I haz the power, 2016-06-27 16:36:26]

Patchset 2 (id:??) landed as
https://crrev.com/b16eadaef85aa0128bf4f74fb96270f0a2479b78
Cr-Commit-Position: refs/heads/master@{#402198}