Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2093973002: Ignore alpha value in extension-specified badge bg color. (Closed)

Created:
4 years, 6 months ago by Evan Stade
Modified:
4 years, 5 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore alpha value in extension-specified badge bg color. (Force full opacity.) BUG=619499 Committed: https://crrev.com/b16eadaef85aa0128bf4f74fb96270f0a2479b78 Cr-Commit-Position: refs/heads/master@{#402198}

Patch Set 1 #

Total comments: 2

Patch Set 2 : commentary #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/extensions/icon_with_badge_image_source.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
Evan Stade
see bug for alternative approaches
4 years, 6 months ago (2016-06-24 18:06:43 UTC) #2
Devlin
On 2016/06/24 18:06:43, Evan Stade wrote: > see bug for alternative approaches Can you post ...
4 years, 6 months ago (2016-06-24 20:59:58 UTC) #3
Evan Stade
On 2016/06/24 20:59:58, Devlin wrote: > On 2016/06/24 18:06:43, Evan Stade wrote: > > see ...
4 years, 6 months ago (2016-06-24 21:32:46 UTC) #4
Devlin
lgtm https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extensions/icon_with_badge_image_source.cc File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right): https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extensions/icon_with_badge_image_source.cc#newcode175 chrome/browser/ui/extensions/icon_with_badge_image_source.cc:175: background_color = SkColorSetA(background_color, SK_AlphaOPAQUE); Let's add a comment ...
4 years, 6 months ago (2016-06-24 23:01:15 UTC) #5
Evan Stade
https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extensions/icon_with_badge_image_source.cc File chrome/browser/ui/extensions/icon_with_badge_image_source.cc (right): https://codereview.chromium.org/2093973002/diff/1/chrome/browser/ui/extensions/icon_with_badge_image_source.cc#newcode175 chrome/browser/ui/extensions/icon_with_badge_image_source.cc:175: background_color = SkColorSetA(background_color, SK_AlphaOPAQUE); On 2016/06/24 23:01:15, Devlin wrote: ...
4 years, 5 months ago (2016-06-27 15:30:03 UTC) #6
Evan Stade
1
4 years, 5 months ago (2016-06-27 15:30:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093973002/20001
4 years, 5 months ago (2016-06-27 15:32:02 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-27 16:34:44 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 16:36:26 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b16eadaef85aa0128bf4f74fb96270f0a2479b78
Cr-Commit-Position: refs/heads/master@{#402198}

Powered by Google App Engine
This is Rietveld 408576698