Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6125)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 2093963003: [ash-md] Uses 'Chrome - <title>' format for browser windows in overview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: [ash-md] Uses 'Chrome - <title>' format for browser windows in overview (accessibility fixes) Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index 1fc240f94b6104094421675d66aa1d21ece22c22..b51b8b10643c1d39ee8225d4e2840baf06d87378 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -308,16 +308,20 @@ void BrowserWindowCocoa::UpdateTitleBar() {
}
NSString* BrowserWindowCocoa::WindowTitle() {
+ const bool accessible = false;
if (alert_state_ == TabAlertState::AUDIO_PLAYING) {
return l10n_util::GetNSStringF(IDS_WINDOW_AUDIO_PLAYING_MAC,
- browser_->GetWindowTitleForCurrentTab(),
+ browser_->GetWindowTitleForCurrentTab(
+ accessible),
base::SysNSStringToUTF16(@"🔊"));
} else if (alert_state_ == TabAlertState::AUDIO_MUTING) {
return l10n_util::GetNSStringF(IDS_WINDOW_AUDIO_MUTING_MAC,
- browser_->GetWindowTitleForCurrentTab(),
+ browser_->GetWindowTitleForCurrentTab(
+ accessible),
base::SysNSStringToUTF16(@"🔇"));
}
- return base::SysUTF16ToNSString(browser_->GetWindowTitleForCurrentTab());
+ return base::SysUTF16ToNSString(
+ browser_->GetWindowTitleForCurrentTab(accessible));
}
void BrowserWindowCocoa::BookmarkBarStateChanged(

Powered by Google App Engine
This is Rietveld 408576698