[ash-md] Uses 'Chrome - <title>' format for browser windows in overview

chrome/browser/ui/browser.cc

Index: chrome/browser/ui/browser.cc
diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc
index 64ab742dcf3ab7a1e8945781e1bf59d60556fb78..64b5f471bb55c4253785577aac2a3d888676bf13 100644
--- a/chrome/browser/ui/browser.cc
+++ b/chrome/browser/ui/browser.cc
@@ -602,12 +602,11 @@ base::string16 Browser::GetWindowTitleForCurrentTab() const {
   if (title.empty())
     title = CoreTabHelper::GetDefaultTitle();
 
-#if defined(OS_MACOSX) || defined(USE_ASH)
-  // On Mac and Ash, we don't want to suffix the page title with the application
-  // name.
+#if defined(OS_MACOSX)
+  // On Mac, we don't want to suffix the page title with the application name.
   return title;
 #endif
-  // Don't append the app name to window titles on app frames and app popups
+  // Don't append the app name to window titles on app frames and app popups.
   return is_app() ?
       title :
       l10n_util::GetStringFUTF16(IDS_BROWSER_WINDOW_TITLE_FORMAT, title);

[sky, 2016/06/24 22:16:12]

Won't this change effect more than just overview mode? Is that expected?

[varkha, 2016/06/24 23:15:32]

My logic was:
- The change is only on Chrome OS (the string remains unchanged elsewhere).
- On Chrome OS only tabbed browser title string is changed.
- tabbed browser windows do not draw opaque frame and so do not use the window
title (and I don't think any window captions use the title anyway - this may
change but likely not for tabbed windows).
- I haven't seen other uses, except for Chrome vox.
- For Chrome vox in overview mode I think it makes sense to use the same changed
title that is visible in overview mode.
- For Chrome vox elsewhere I have modified accessibility title to not include
the additional "Chrome - ". I've tried it and it sounded wrong for opening
windows and such.

I have also noticed and fixed some tests that needed update.