[ash-md] Uses 'Chrome - <title>' format for browser windows in overview

[ash-md] Uses 'Chrome - <title>' format for browser windows in overview

Previously format used on Chrome OS (visible in overview mode captions)
was just '<title>' for all windows. Now tabbed browser windows use
'Chrome - <title>' while popups and web app windows still use '<title'.

BUG=621168
Committed: https://crrev.com/48f84c4b709b59d6c27f341aadc6fb52d1094633
Cr-Commit-Position: refs/heads/master@{#402228}

[varkha, 2016-06-24 21:03:18]

varkha@chromium.org changed reviewers:
+ sky@chromium.org

[varkha, 2016-06-24 21:03:19]

sky@, can you please take a look? This is what designers asked for on Chrome OS.
I decided not to make this change dependent on MD flag. I think it is small
enough and plumbing ash::MaterialDesignController into chrome/ seems like a
wrong thing to do here.
Thanks!

[varkha, 2016-06-24 21:03:37]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 21:04:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 21:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 21:40:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-06-24 22:16:12]

https://codereview.chromium.org/2093963003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2093963003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:612:
l10n_util::GetStringFUTF16(IDS_BROWSER_WINDOW_TITLE_FORMAT, title);
Won't this change effect more than just overview mode? Is that expected?

[varkha, 2016-06-24 22:53:12]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 22:53:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 23:04:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 23:04:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[varkha, 2016-06-24 23:15:32]

https://codereview.chromium.org/2093963003/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2093963003/diff/1/chrome/browser/ui/browser.c...
chrome/browser/ui/browser.cc:612:
l10n_util::GetStringFUTF16(IDS_BROWSER_WINDOW_TITLE_FORMAT, title);
On 2016/06/24 22:16:12, sky wrote:
> Won't this change effect more than just overview mode? Is that expected?

My logic was:
- The change is only on Chrome OS (the string remains unchanged elsewhere).
- On Chrome OS only tabbed browser title string is changed.
- tabbed browser windows do not draw opaque frame and so do not use the window
title (and I don't think any window captions use the title anyway - this may
change but likely not for tabbed windows).
- I haven't seen other uses, except for Chrome vox.
- For Chrome vox in overview mode I think it makes sense to use the same changed
title that is visible in overview mode.
- For Chrome vox elsewhere I have modified accessibility title to not include
the additional "Chrome - ". I've tried it and it sounded wrong for opening
windows and such.

I have also noticed and fixed some tests that needed update.

[varkha, 2016-06-24 23:17:40]

Patchset #2 (id:20001) has been deleted

[varkha, 2016-06-24 23:17:47]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 23:18:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 23:29:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 23:29:30]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[varkha, 2016-06-24 23:36:01]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 23:36:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-06-24 23:37:47]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-06-25 00:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-25 00:46:56]

Dry run: This issue passed the CQ dry run.

[sky, 2016-06-25 14:59:37]

Ok, makes sense. One question about the naming of the variable.

https://codereview.chromium.org/2093963003/diff/60001/chrome/browser/ui/brows...
File chrome/browser/ui/browser.h (right):

https://codereview.chromium.org/2093963003/diff/60001/chrome/browser/ui/brows...
chrome/browser/ui/browser.h:305: base::string16 GetWindowTitleForCurrentTab(bool
accessible) const;
How about naming accessible more explicitly: include_app_name?

[varkha, 2016-06-27 14:59:15]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 14:59:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-06-27 15:00:24]

I've also reversed the logic to match the new variable name. PTAL.

https://codereview.chromium.org/2093963003/diff/60001/chrome/browser/ui/brows...
File chrome/browser/ui/browser.h (right):

https://codereview.chromium.org/2093963003/diff/60001/chrome/browser/ui/brows...
chrome/browser/ui/browser.h:305: base::string16 GetWindowTitleForCurrentTab(bool
accessible) const;
On 2016/06/25 14:59:37, sky wrote:
> How about naming accessible more explicitly: include_app_name?

Done.

[varkha, 2016-06-27 15:05:42]

Patchset #3 (id:80001) has been deleted

[varkha, 2016-06-27 15:05:49]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 15:06:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-06-27 15:06:56]

The CQ bit was unchecked by varkha@chromium.org

[varkha, 2016-06-27 15:08:31]

Patchset #3 (id:100001) has been deleted

[varkha, 2016-06-27 15:09:31]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 15:09:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-06-27 16:11:38]

LGTM

https://codereview.chromium.org/2093963003/diff/120001/chrome/browser/ui/brow...
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2093963003/diff/120001/chrome/browser/ui/brow...
chrome/browser/ui/browser.cc:611: // for accessibility.
nit: update accessibility.

[commit-bot: I haz the power, 2016-06-27 16:17:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:17:45]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-06-27 16:37:40]

https://codereview.chromium.org/2093963003/diff/120001/chrome/browser/ui/brow...
File chrome/browser/ui/browser.cc (right):

https://codereview.chromium.org/2093963003/diff/120001/chrome/browser/ui/brow...
chrome/browser/ui/browser.cc:611: // for accessibility.
On 2016/06/27 16:11:38, sky wrote:
> nit: update accessibility.

Done.

[varkha, 2016-06-27 16:40:27]

The CQ bit was checked by varkha@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 16:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[varkha, 2016-06-27 16:51:12]

FTR: Confirmed that chromevox_tests BackgroundTest.GlobsToRegExp test is flaky
without this patch.

[commit-bot: I haz the power, 2016-06-27 17:26:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 17:26:05]

Dry run: This issue passed the CQ dry run.

[varkha, 2016-06-27 18:02:27]

The CQ bit was checked by varkha@chromium.org

[varkha, 2016-06-27 18:02:27]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2093963003/#ps140001
(title: "[ash-md] Uses 'Chrome - <title>' format for browser windows in overview
(comment)")

[commit-bot: I haz the power, 2016-06-27 18:03:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 18:10:46]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2016-06-27 18:13:14]

Description was changed from

==========
[ash-md] Uses 'Chrome - <title>' format for browser windows in overview

Previously format used on Chrome OS (visible in overview mode captions)
was just '<title>' for all windows. Now tabbed browser windows use
'Chrome - <title>' while popups and web app windows still use '<title'.

BUG=621168
==========

to

==========
[ash-md] Uses 'Chrome - <title>' format for browser windows in overview

Previously format used on Chrome OS (visible in overview mode captions)
was just '<title>' for all windows. Now tabbed browser windows use
'Chrome - <title>' while popups and web app windows still use '<title'.

BUG=621168

Committed: https://crrev.com/48f84c4b709b59d6c27f341aadc6fb52d1094633
Cr-Commit-Position: refs/heads/master@{#402228}
==========

[commit-bot: I haz the power, 2016-06-27 18:13:15]

Patchset 4 (id:??) landed as
https://crrev.com/48f84c4b709b59d6c27f341aadc6fb52d1094633
Cr-Commit-Position: refs/heads/master@{#402228}