Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2093963002: Revert of Adding checkbox for sRGB SkColor flag (Closed)

Created:
4 years, 5 months ago by Brian Osman
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert of Adding checkbox for sRGB SkColor flag (patchset #1 id:1 of https://codereview.chromium.org/1900233002/ ) Reason for revert: Removing the underlying feature - that flag will always be on now. Original issue's description: > Adding checkbox for sRGB SkColor flag > > Screenshot: https://screenshot.googleplex.com/Kv1CmOEuCvp.png > > Backend change: https://codereview.chromium.org/1902143002/ > > BUG=skia: > > Committed: https://skia.googlesource.com/buildbot/+/5f91d4073f3bf021b503e5faf8886fdb518e5348 TBR=jcgregorio@google.com,ethannicholas@google.com,reed@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=skia: Committed: https://skia.googlesource.com/buildbot/+/1edc54a5bf6966f280b02aad109188657d53ca5c

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -20 lines) Patch
M debugger/res/imp/app.html View 1 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Brian Osman
Created Revert of Adding checkbox for sRGB SkColor flag
4 years, 5 months ago (2016-06-24 16:03:01 UTC) #1
jcgregorio
lgtm
4 years, 5 months ago (2016-06-24 16:04:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093963002/1
4 years, 5 months ago (2016-06-24 16:08:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/4229)
4 years, 5 months ago (2016-06-24 16:09:48 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093963002/40001
4 years, 5 months ago (2016-06-24 16:22:28 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-24 16:24:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2093963002/40001
4 years, 5 months ago (2016-06-24 16:25:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://skia.googlesource.com/buildbot/+/1edc54a5bf6966f280b02aad109188657d53ca5c
4 years, 5 months ago (2016-06-24 16:25:55 UTC) #15
jcgregorio
4 years, 5 months ago (2016-06-24 16:33:37 UTC) #16
Message was sent while issue was closed.
On 2016/06/24 at 16:25:55, commit-bot wrote:
> Committed patchset #2 (id:40001) as
https://skia.googlesource.com/buildbot/+/1edc54a5bf6966f280b02aad109188657d53...

Pushed to prod.

Powered by Google App Engine
This is Rietveld 408576698