chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm - Issue 2093953002: Introduce a new API to handle native notification clicks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

Issue 2093953002: Introduce a new API to handle native notification clicks (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/notification_operation_common.h ('K') | « chrome/browser/ui/cocoa/notifications/notification_builder_mac.mm ('k') | chrome/browser/ui/cocoa/notifications/notification_constants_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

diff --git a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

index 9baa9f55b9bd74e2a3c1f2cfbd4ba360e8020136..3e0987eec77b2e4a6cf9a88a62fd1b82597b923d 100644

--- a/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

+++ b/chrome/browser/ui/cocoa/notifications/notification_builder_mac_unittest.mm

@@ -22,6 +22,7 @@ TEST(NotificationBuilderMacTest, TestNotificationNoButtons) {

[builder setNotificationId:@"notificationId"];

[builder setProfileId:@"profileId"];

[builder setIncognito:false];

+ [builder setNotificationType:[NSNumber numberWithInt:1]];

NSUserNotification* notification = [builder buildUserNotification];

EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));

@@ -47,6 +48,7 @@ TEST(NotificationBuilderMacTest, TestNotificationOneButton) {

[builder setNotificationId:@"notificationId"];

[builder setProfileId:@"profileId"];

[builder setIncognito:false];

+ [builder setNotificationType:[NSNumber numberWithInt:0]];

NSUserNotification* notification = [builder buildUserNotification];

@@ -78,6 +80,7 @@ TEST(NotificationBuilderMacTest, TestNotificationTwoButtons) {

[builder setNotificationId:@"notificationId"];

[builder setProfileId:@"profileId"];

[builder setIncognito:false];

+ [builder setNotificationType:[NSNumber numberWithInt:0]];

NSUserNotification* notification = [builder buildUserNotification];

@@ -108,6 +111,7 @@ TEST(NotificationBuilderMacTest, TestUserInfo) {

[builder setOrigin:@"https://www.miguel.com"];

[builder setNotificationId:@"Notification1"];

[builder setIncognito:true];

+ [builder setNotificationType:[NSNumber numberWithInt:0]];

NSUserNotification* notification = [builder buildUserNotification];

EXPECT_EQ("Title", base::SysNSStringToUTF8([notification title]));

@@ -138,6 +142,7 @@ TEST(NotificationBuilderMacTest, TestBuildDictionary) {

[sourceBuilder setNotificationId:@"notificationId"];

[sourceBuilder setProfileId:@"profileId"];

[sourceBuilder setIncognito:false];

+ [sourceBuilder setNotificationType:[NSNumber numberWithInt:1]];

notificationData = [sourceBuilder buildDictionary];

}

base::scoped_nsobject<NotificationBuilder> finalBuilder(