Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 209393014: Merged r20022 into 3.24 branch. (Closed)

Created:
6 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Merged r20022 into 3.24 branch. Apply numeric casts correctly in typed arrays and related code. BUG=353004 LOG=N R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -26 lines) Patch
M src/api.cc View 1 chunk +1 line, -14 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +4 lines, -1 line 0 comments Download
M src/runtime.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/runtime.cc View 4 chunks +40 lines, -2 lines 0 comments Download
M src/typedarray.js View 5 chunks +30 lines, -8 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/regress/regress-353004.js View 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dmitry Lomov (no reviews)
6 years, 9 months ago (2014-03-25 07:46:47 UTC) #1
Sven Panne
LGTM (rubberstamped)
6 years, 9 months ago (2014-03-25 07:48:14 UTC) #2
Dmitry Lomov (no reviews)
6 years, 9 months ago (2014-03-25 07:48:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20222.

Powered by Google App Engine
This is Rietveld 408576698