Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 209393013: Reorganize text input related OWNERS file based on current status. (Closed)

Created:
6 years, 9 months ago by Seigo Nonaka
Modified:
6 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, penghuang+watch_chromium.org, nona+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, James Su, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Reorganize text input related OWNERS file based on current status. Update owners file based on latest project status since many of owners in text input are now working on different team. yukishiino@ will be the primary reviewer of IME binding(ui/base/ime) for all platform(Chrome OS, Linux Aura, and Windows Aura). shuchen@ will be the primary reviewer of Chrome OS IME engine including extension binding. mukai@ will be the primary reviewer of IME specific UI components. BUG=None TEST=None NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260076

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add yukishiino to ash/ime #

Total comments: 2

Patch Set 3 : Update extension OWNER's match rule #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -11 lines) Patch
M ash/ime/OWNERS View 1 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/OWNERS View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/OWNERS View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/input_ime/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/ime/OWNERS View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/base/ime/OWNERS View 1 chunk +6 lines, -7 lines 0 comments Download
M ui/views/ime/OWNERS View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Seigo Nonaka
PTAL.
6 years, 9 months ago (2014-03-25 05:50:00 UTC) #1
Yuki
lgtm
6 years, 9 months ago (2014-03-25 05:54:24 UTC) #2
Shu Chen
lgtm
6 years, 9 months ago (2014-03-25 05:54:49 UTC) #3
Jun Mukai
https://codereview.chromium.org/209393013/diff/1/ash/ime/OWNERS File ash/ime/OWNERS (right): https://codereview.chromium.org/209393013/diff/1/ash/ime/OWNERS#newcode6 ash/ime/OWNERS:6: nona@chromium.org please add yukishiino here ;)
6 years, 9 months ago (2014-03-25 20:12:35 UTC) #4
Seigo Nonaka
https://codereview.chromium.org/209393013/diff/1/ash/ime/OWNERS File ash/ime/OWNERS (right): https://codereview.chromium.org/209393013/diff/1/ash/ime/OWNERS#newcode6 ash/ime/OWNERS:6: nona@chromium.org On 2014/03/25 20:12:35, Jun Mukai wrote: > please ...
6 years, 9 months ago (2014-03-26 04:41:33 UTC) #5
Seigo Nonaka
+kalman Adding extension owner. Could you take a look at chrome/browser/chromeos/extensions/OWNERS change? Thank you.
6 years, 9 months ago (2014-03-26 04:47:07 UTC) #6
Jun Mukai
lgtm
6 years, 9 months ago (2014-03-26 05:57:21 UTC) #7
not at google - send to devlin
lgtm https://codereview.chromium.org/209393013/diff/40001/chrome/browser/chromeos/extensions/OWNERS File chrome/browser/chromeos/extensions/OWNERS (right): https://codereview.chromium.org/209393013/diff/40001/chrome/browser/chromeos/extensions/OWNERS#newcode23 chrome/browser/chromeos/extensions/OWNERS:23: per-file input_method_api.cc=shuchen@chromium.org would prefer if these API implementations ...
6 years, 9 months ago (2014-03-26 14:24:14 UTC) #8
Seigo Nonaka
https://codereview.chromium.org/209393013/diff/40001/chrome/browser/chromeos/extensions/OWNERS File chrome/browser/chromeos/extensions/OWNERS (right): https://codereview.chromium.org/209393013/diff/40001/chrome/browser/chromeos/extensions/OWNERS#newcode23 chrome/browser/chromeos/extensions/OWNERS:23: per-file input_method_api.cc=shuchen@chromium.org Thank you for your suggestion. I modified ...
6 years, 9 months ago (2014-03-28 05:56:02 UTC) #9
Seigo Nonaka
Thank you for your review! Landing with NOTRY since this only changes OWNERS file.
6 years, 9 months ago (2014-03-28 05:57:00 UTC) #10
Seigo Nonaka
The CQ bit was checked by nona@chromium.org
6 years, 9 months ago (2014-03-28 05:57:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/209393013/130001
6 years, 9 months ago (2014-03-28 05:58:01 UTC) #12
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 06:00:31 UTC) #13
Message was sent while issue was closed.
Change committed as 260076

Powered by Google App Engine
This is Rietveld 408576698