Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: gclient.py

Issue 209393006: Add warning batching in gclient_utils (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Address comments Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gclient.py
diff --git a/gclient.py b/gclient.py
index 8dcb93b6ab039c0ea974dcccab2ce991ce0c2a67..7a13a5d525ed0572caef62ac3742aa217e21e836 100755
--- a/gclient.py
+++ b/gclient.py
@@ -1052,7 +1052,7 @@ solutions = [
scm = gclient_scm.CreateSCM(dep.url, self.root_dir, dep.name)
actual_url = scm.GetActualRemoteURL()
if actual_url and not scm.DoesRemoteURLMatch():
- print >> sys.stderr, ('''
+ gclient_utils.AddWarning('''
################################################################################
################################### WARNING! ###################################
################################################################################
@@ -1957,6 +1957,8 @@ def Main(argv):
except (gclient_utils.Error, subprocess2.CalledProcessError), e:
print >> sys.stderr, 'Error: %s' % str(e)
return 1
+ finally:
+ gclient_utils.PrintWarnings()
if '__main__' == __name__:
« no previous file with comments | « no previous file | gclient_utils.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698