Add warning batching in gclient_utils

gclient_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic utils."""
 
 import codecs
 import cStringIO
 import logging
 import os
 import pipes
 import platform
 import Queue
 import re
 import stat
 import subprocess
 import sys
 import tempfile
 import threading
 import time
 import urlparse
 
 import subprocess2
 
 
 RETRY_MAX = 3
 RETRY_INITIAL_SLEEP = 0.5
 
 
+_WARNINGS = []
+
+
 class Error(Exception):
   """gclient exception class."""
   def __init__(self, msg, *args, **kwargs):
     index = getattr(threading.currentThread(), 'index', 0)
     if index:
       msg = '\n'.join('%d> %s' % (index, l) for l in msg.splitlines())
     super(Error, self).__init__(msg, *args, **kwargs)
 
 
+def PrintWarnings():
+  """Print any accumulated warnings."""

[M-A Ruel, 2014/03/24 17:53:06]

Prints

[borenet, 2014/03/24 18:01:48]

Done.

+  if _WARNINGS:
+    print >> sys.stderr, '\n\nWarnings:'
+    for warning in _WARNINGS:
+      print >> sys.stderr, warning
+
+
+def AddWarning(msg):
+  """Add the given warning message to the list of accumulated warnings."""

[M-A Ruel, 2014/03/24 17:53:06]

Adds

[borenet, 2014/03/24 18:01:48]

Done.

+  _WARNINGS.append(msg)

[M-A Ruel, 2014/03/24 17:53:06]

In theory you'd need a lock. In practice, it's not a big deal.

[borenet, 2014/03/24 18:01:48]

My understanding is that list.append is thread-safe.  I guess we could still run
into trouble if we were running PrintWarnings throughout, but I think this is
okay.

+
+
 def SplitUrlRevision(url):
   """Splits url and returns a two-tuple: url, rev"""
   if url.startswith('ssh:'):
     # Make sure ssh://user-name@example.com/~/test.git@stable works
     regex = r'(ssh://(?:[-.\w]+@)?[-\w:\.]+/[-~\w\./]+)(?:@(.+))?'
     components = re.search(regex, url).groups()
   else:
     components = url.split('@', 1)
     if len(components) == 1:
       components += [None]
@@ skipping 925 matching lines @@
   else:
     return '512m'
 
 def DefaultIndexPackConfig():
   """Return reasonable default values for configuring git-index-pack.
 
   Experiments suggest that higher values for pack.threads don't improve
   performance."""
   return ['-c', 'pack.threads=5', '-c',
           'core.deltaBaseCacheLimit=%s' % DefaultDeltaBaseCacheLimit()]