Add warning batching in gclient_utils

gclient_utils.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generic utils."""
 
+import atexit
 import codecs
 import cStringIO
 import logging
 import os
 import pipes
 import platform
 import Queue
 import re
 import stat
 import subprocess
 import sys
 import tempfile
 import threading
 import time
 import urlparse
 
 import subprocess2
 
 
 RETRY_MAX = 3
 RETRY_INITIAL_SLEEP = 0.5
 
 
+_WARNINGS = []
+
+
 class Error(Exception):
   """gclient exception class."""
   def __init__(self, msg, *args, **kwargs):
     index = getattr(threading.currentThread(), 'index', 0)
     if index:
       msg = '\n'.join('%d> %s' % (index, l) for l in msg.splitlines())
     super(Error, self).__init__(msg, *args, **kwargs)
 
 
+def _DisplayWarningsAtExit():
+  """Display any stored warnings when the program exits."""
+  if _WARNINGS:
+    print >> sys.stderr, '\n\nWarnings:'
+    for warning in _WARNINGS:
+      print >> sys.stderr, warning
+
+atexit.register(_DisplayWarningsAtExit)

[M-A Ruel, 2014/03/24 16:25:30]

I'd prefer something more formal, a try/finally in the main loop instead of
relying on atexit.

+
+
+def WarnOnExit(msg):
+  """Display the given warning when the program exits."""
+  _WARNINGS.append(msg)
+
+
 def SplitUrlRevision(url):
   """Splits url and returns a two-tuple: url, rev"""
   if url.startswith('ssh:'):
     # Make sure ssh://user-name@example.com/~/test.git@stable works
     regex = r'(ssh://(?:[-.\w]+@)?[-\w:\.]+/[-~\w\./]+)(?:@(.+))?'
     components = re.search(regex, url).groups()
   else:
     components = url.split('@', 1)
     if len(components) == 1:
       components += [None]
@@ skipping 925 matching lines @@
   else:
     return '512m'
 
 def DefaultIndexPackConfig():
   """Return reasonable default values for configuring git-index-pack.
 
   Experiments suggest that higher values for pack.threads don't improve
   performance."""
   return ['-c', 'pack.threads=5', '-c',
           'core.deltaBaseCacheLimit=%s' % DefaultDeltaBaseCacheLimit()]