[telemetry] Add support for setting browser logging verbosity

[telemetry] Add support for setting browser logging verbosity

This patch replaces the existing enable_logging boolean field in
BrowserOptions (--enable-browser-logging flag) to a logging_verbosity
integer field (--browser-logging-verbosity flag).

  BEFORE                   AFTER
  [no flag]                --browser-logging-verbosity none [or no flag]
  [NOT SUPPORTED]          --browser-logging-verbosity non-verbose
  --enable-browser-logging --browser-logging-verbosity verbose

Note that the old flag as well as the field are still supported, but
they're marked as deprecated.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=chromium:623058
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e3c8179b5c82fc346d35e31aa334c5226a20db05

[petrcermak, 2016-06-24 14:01:35]

Patchset #1 (id:1) has been deleted

[petrcermak, 2016-06-24 14:16:03]

Description was changed from

==========
[telemetry] Add support for setting browser logging verbosity
==========

to

==========
[telemetry] Add support for setting browser logging verbosity

This patch adds a logging_verbosity integer field to BrowserOptions
and a corresponding --browser-logging-verbosity command-line flag.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=623058
==========

[petrcermak, 2016-06-24 14:25:43]

Description was changed from

==========
[telemetry] Add support for setting browser logging verbosity

This patch adds a logging_verbosity integer field to BrowserOptions
and a corresponding --browser-logging-verbosity command-line flag.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=623058
==========

to

==========
[telemetry] Add support for setting browser logging verbosity

This patch adds a logging_verbosity integer field to BrowserOptions
and a corresponding --browser-logging-verbosity command-line flag.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=chromium:623058
==========

[petrcermak, 2016-06-24 14:26:19]

Patchset #2 (id:40001) has been deleted

[petrcermak, 2016-06-24 14:28:27]

Patchset #2 (id:60001) has been deleted

[petrcermak, 2016-06-24 14:28:42]

petrcermak@chromium.org changed reviewers:
+ nednguyen@google.com

[petrcermak, 2016-06-24 14:28:42]

PTAL.

Thanks,
Petr

[nednguyen, 2016-06-24 14:41:08]

https://codereview.chromium.org/2093923002/diff/80001/telemetry/telemetry/int...
File telemetry/telemetry/internal/browser/browser_options.py (right):

https://codereview.chromium.org/2093923002/diff/80001/telemetry/telemetry/int...
telemetry/telemetry/internal/browser/browser_options.py:200: if
self.logging_verbosity is not None:
Hmhh, can we have less flags here? logging_verbosity None = disable logging?

[petrcermak, 2016-06-27 15:18:28]

Description was changed from

==========
[telemetry] Add support for setting browser logging verbosity

This patch adds a logging_verbosity integer field to BrowserOptions
and a corresponding --browser-logging-verbosity command-line flag.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=chromium:623058
==========

to

==========
[telemetry] Add support for setting browser logging verbosity

This patch replaces the existing enable_logging boolean field in
BrowserOptions (--enable-browser-logging flag) to a logging_verbosity
integer field (--browser-logging-verbosity flag).

  BEFORE                   AFTER
  [no flag]                --browser-logging-verbosity none [or no flag]
  [NOT SUPPORTED]          --browser-logging-verbosity non-verbose
  --enable-browser-logging --browser-logging-verbosity verbose

Note that the old flag as well as the field are still supported, but
they're marked as deprecated.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=chromium:623058
==========

[petrcermak, 2016-06-27 15:18:45]

Thanks for your feedback. PTAL.

Petr

https://codereview.chromium.org/2093923002/diff/80001/telemetry/telemetry/int...
File telemetry/telemetry/internal/browser/browser_options.py (right):

https://codereview.chromium.org/2093923002/diff/80001/telemetry/telemetry/int...
telemetry/telemetry/internal/browser/browser_options.py:200: if
self.logging_verbosity is not None:
On 2016/06/24 14:41:08, nednguyen wrote:
> Hmhh, can we have less flags here? logging_verbosity None = disable logging?

Changed this to an enum as discussed.

[nednguyen, 2016-06-27 15:57:01]

lgtm

https://codereview.chromium.org/2093923002/diff/100001/telemetry/telemetry/in...
File telemetry/telemetry/internal/browser/browser_options.py (right):

https://codereview.chromium.org/2093923002/diff/100001/telemetry/telemetry/in...
telemetry/telemetry/internal/browser/browser_options.py:432: def
enable_logging(self, value):
Can you add warnings.warn('enable_logging is deprecated. Please use
logging_verbosity instead')?

[petrcermak, 2016-06-27 18:00:14]

Thanks for your comments.

Petr

https://codereview.chromium.org/2093923002/diff/100001/telemetry/telemetry/in...
File telemetry/telemetry/internal/browser/browser_options.py (right):

https://codereview.chromium.org/2093923002/diff/100001/telemetry/telemetry/in...
telemetry/telemetry/internal/browser/browser_options.py:432: def
enable_logging(self, value):
On 2016/06/27 15:57:01, nednguyen wrote:
> Can you add warnings.warn('enable_logging is deprecated. Please use
> logging_verbosity instead')?

Done.

[petrcermak, 2016-06-27 18:00:20]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-06-27 18:00:20]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2093923002/#ps130001
(title: "Update tests")

[commit-bot: I haz the power, 2016-06-27 18:00:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 18:13:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 18:13:12]

Try jobs failed on following builders:
  Catapult Mac Tryserver on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Ma...)

[petrcermak, 2016-06-27 19:03:35]

The CQ bit was checked by petrcermak@chromium.org

[petrcermak, 2016-06-27 19:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2093923002/#ps150001
(title: "Fix test")

[commit-bot: I haz the power, 2016-06-27 19:03:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 19:28:07]

Description was changed from

==========
[telemetry] Add support for setting browser logging verbosity

This patch replaces the existing enable_logging boolean field in
BrowserOptions (--enable-browser-logging flag) to a logging_verbosity
integer field (--browser-logging-verbosity flag).

  BEFORE                   AFTER
  [no flag]                --browser-logging-verbosity none [or no flag]
  [NOT SUPPORTED]          --browser-logging-verbosity non-verbose
  --enable-browser-logging --browser-logging-verbosity verbose

Note that the old flag as well as the field are still supported, but
they're marked as deprecated.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=chromium:623058
==========

to

==========
[telemetry] Add support for setting browser logging verbosity

This patch replaces the existing enable_logging boolean field in
BrowserOptions (--enable-browser-logging flag) to a logging_verbosity
integer field (--browser-logging-verbosity flag).

  BEFORE                   AFTER
  [no flag]                --browser-logging-verbosity none [or no flag]
  [NOT SUPPORTED]          --browser-logging-verbosity non-verbose
  --enable-browser-logging --browser-logging-verbosity verbose

Note that the old flag as well as the field are still supported, but
they're marked as deprecated.

Rationale: We want to be able to enable browser logging with custom
verbosity level (--v=0) rather than the default one (--v=1).

BUG=chromium:623058

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-06-27 19:28:08]

Committed patchset #6 (id:150001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...