Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2093833002: [Mac/GN] Do not use ELF-only cflags on Mac. (Closed)

Created:
4 years, 6 months ago by Robert Sesek
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac/GN] Do not use ELF-only cflags on Mac. This removes -fdata-sections, -ffunction-sections, and -fno-ident. BUG=622889 R=dpranke@chromium.org Committed: https://crrev.com/054b2e4f537d040e12f874c633be75462d93b406 Cr-Commit-Position: refs/heads/master@{#401789}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M build/config/compiler/BUILD.gn View 2 chunks +14 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Robert Sesek
4 years, 6 months ago (2016-06-23 23:06:38 UTC) #1
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-23 23:25:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093833002/1
4 years, 6 months ago (2016-06-24 00:23:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-24 02:11:51 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-24 02:14:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/054b2e4f537d040e12f874c633be75462d93b406
Cr-Commit-Position: refs/heads/master@{#401789}

Powered by Google App Engine
This is Rietveld 408576698