Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 209383015: No need to clear the style resolver in Document::childrenChanged (Closed)

Created:
6 years, 9 months ago by esprehn
Modified:
6 years, 9 months ago
CC:
blink-reviews, sof, eae+blinkwatch, dglazkov+blink, adamk+blink_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

No need to clear the style resolver in Document::childrenChanged If you delete the documentElement then that also means all <style> and <link> elements must have been removed from the document so the StyleResolver should already be reset or cleared and we don't need to call clearStyleResolver() from inside Document::childrenChanged. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M Source/core/dom/Document.cpp View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
esprehn
6 years, 9 months ago (2014-03-25 03:07:08 UTC) #1
abarth-chromium
What if you have multiple element children of the document?
6 years, 9 months ago (2014-03-25 04:12:12 UTC) #2
esprehn
On 2014/03/25 04:12:12, abarth wrote: > What if you have multiple element children of the ...
6 years, 9 months ago (2014-03-25 04:26:01 UTC) #3
ojan
On 2014/03/25 04:12:12, abarth wrote: > What if you have multiple element children of the ...
6 years, 9 months ago (2014-03-25 04:27:04 UTC) #4
ojan
lgtm
6 years, 9 months ago (2014-03-25 04:27:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/esprehn@chromium.org/209383015/1
6 years, 9 months ago (2014-03-25 04:27:43 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-25 05:34:25 UTC) #7
Message was sent while issue was closed.
Change committed as 169911

Powered by Google App Engine
This is Rietveld 408576698