Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 209383013: Increase the timeout for media element activation tests (Closed)

Created:
6 years, 9 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, eric.carlson_apple.com
Visibility:
Public.

Description

Increase the timeout for media element activation tests The async tests wait for the canplay event (HAVE_FUTURE_DATA) which depends on the network. 10 seconds should be enough. BUG=355489

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M LayoutTests/media/activation-behavior.html View 7 chunks +14 lines, -6 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 9 months ago (2014-03-24 18:38:20 UTC) #1
acolwell GONE FROM CHROMIUM
https://codereview.chromium.org/209383013/diff/1/LayoutTests/media/activation-behavior.html File LayoutTests/media/activation-behavior.html (right): https://codereview.chromium.org/209383013/diff/1/LayoutTests/media/activation-behavior.html#newcode8 LayoutTests/media/activation-behavior.html:8: setup({ timeout: 10000 }); It would be nice to ...
6 years, 9 months ago (2014-03-25 22:57:55 UTC) #2
philipj_slow
Dirk, do you have any ideas for how to solve this generally? https://codereview.chromium.org/209383013/diff/1/LayoutTests/media/activation-behavior.html File LayoutTests/media/activation-behavior.html ...
6 years, 9 months ago (2014-03-26 09:06:42 UTC) #3
acolwell GONE FROM CHROMIUM
On 2014/03/26 09:06:42, philipj wrote: > Dirk, do you have any ideas for how to ...
6 years, 8 months ago (2014-03-26 16:37:05 UTC) #4
philipj_slow
6 years, 8 months ago (2014-03-26 17:23:45 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698