Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/js_backend/minify_namer.dart

Issue 209383005: Revert "Rename [call$...] properties to [$...] in compiled code." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 /** 7 /**
8 * Assigns JavaScript identifiers to Dart variables, class-names and members. 8 * Assigns JavaScript identifiers to Dart variables, class-names and members.
9 */ 9 */
10 class MinifyNamer extends Namer { 10 class MinifyNamer extends Namer {
11 MinifyNamer(Compiler compiler) : super(compiler) { 11 MinifyNamer(Compiler compiler) : super(compiler) {
12 reserveBackendNames(); 12 reserveBackendNames();
13 } 13 }
14 14
15 String get isolateName => 'I'; 15 String get isolateName => 'I';
16 String get isolatePropertiesName => 'p'; 16 String get isolatePropertiesName => 'p';
17 bool get shouldMinify => true; 17 bool get shouldMinify => true;
18 18
19 final String getterPrefix = 'g'; 19 final String getterPrefix = 'g';
20 final String setterPrefix = 's'; 20 final String setterPrefix = 's';
21 final String callPrefix = ''; // this will create function names $<n>
22 21
23 static const ALPHABET_CHARACTERS = 52; // a-zA-Z. 22 static const ALPHABET_CHARACTERS = 52; // a-zA-Z.
24 static const ALPHANUMERIC_CHARACTERS = 62; // a-zA-Z0-9. 23 static const ALPHANUMERIC_CHARACTERS = 62; // a-zA-Z0-9.
25 24
26 // You can pass an invalid identifier to this and unlike its non-minifying 25 // You can pass an invalid identifier to this and unlike its non-minifying
27 // counterpart it will never return the proposedName as the new fresh name. 26 // counterpart it will never return the proposedName as the new fresh name.
28 String getFreshName(String proposedName, 27 String getFreshName(String proposedName,
29 Set<String> usedNames, 28 Set<String> usedNames,
30 Map<String, String> suggestedNames, 29 Map<String, String> suggestedNames,
31 {bool ensureSafe: true}) { 30 {bool ensureSafe: true}) {
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 } 215 }
217 216
218 int _alphaNumericNumber(int x) { 217 int _alphaNumericNumber(int x) {
219 if (x >= ALPHANUMERIC_CHARACTERS) x %= ALPHANUMERIC_CHARACTERS; 218 if (x >= ALPHANUMERIC_CHARACTERS) x %= ALPHANUMERIC_CHARACTERS;
220 if (x < 26) return $a + x; 219 if (x < 26) return $a + x;
221 if (x < 52) return $A + x - 26; 220 if (x < 52) return $A + x - 26;
222 return $0 + x - 52; 221 return $0 + x - 52;
223 } 222 }
224 223
225 } 224 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698