Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2093813002: Allow null in Dart_SetRootLibrary. (Closed)

Created:
4 years, 6 months ago by rmacnak
Modified:
4 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M runtime/vm/dart_api_impl.cc View 1 chunk +8 lines, -7 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
For clearing root library for service isolate when running from a JIT snapshot in Flutter.
4 years, 6 months ago (2016-06-23 23:21:17 UTC) #2
Florian Schneider
lgtm
4 years, 6 months ago (2016-06-23 23:28:11 UTC) #3
rmacnak
4 years, 6 months ago (2016-06-24 00:22:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a86111854a42d2b1bb13091482bd6202ef16f507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698