Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2093763002: Implement WaitSetDispatcher::WaitSetWaitImpl(). (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Implement WaitSetDispatcher::WaitSetWaitImpl(). It should theoretically work (ha), and there are some *very* basic (single-threaded) tests. Still to do: * Add less basic (e.g., multithreaded) tests. * Hook it up to Core and plumb it out (with thunks, etc.). * Write even more tests. R=vardhan@google.com BUG=#350 Committed: https://chromium.googlesource.com/external/mojo/+/1607bb179aa874eb1603724e6a25164c99776632

Patch Set 1 #

Patch Set 2 : fix removal race #

Patch Set 3 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -49 lines) Patch
M mojo/edk/system/memory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/system/shared_buffer_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.h View 1 4 chunks +15 lines, -2 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher.cc View 1 2 6 chunks +122 lines, -9 lines 0 comments Download
M mojo/edk/system/wait_set_dispatcher_unittest.cc View 2 chunks +191 lines, -28 lines 0 comments Download
M mojo/public/c/system/wait_set.h View 2 chunks +5 lines, -8 lines 0 comments Download

Dependent Patchsets:

Issue 2090353004 Patch 40001

Messages

Total messages: 5 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-23 20:21:17 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-06-24 18:11:32 UTC) #2
vardhan
lgtm
4 years, 6 months ago (2016-06-24 20:10:29 UTC) #3
viettrungluu
4 years, 6 months ago (2016-06-24 20:41:33 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
1607bb179aa874eb1603724e6a25164c99776632 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698