Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43541/steps/webkit_tests/logs/stdio).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
TBR=wangxianzhu

Committed: https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b
Cr-Commit-Position: refs/heads/master@{#401876}

[blundell, 2016-06-24 14:11:10]

Description was changed from

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and
Win10. Hence, moving it back to NeedsManualRebaseline.

BUG=600008
==========

to

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=600008
==========

[blundell, 2016-06-24 14:11:58]

Description was changed from

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=600008
==========

to

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
==========

[blundell, 2016-06-24 14:15:36]

Description was changed from

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
==========

to

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
TBR=wangxianzhu
==========

[blundell, 2016-06-24 14:15:36]

blundell@chromium.org changed reviewers:
+ wangxianzhu@chromium.org

[blundell, 2016-06-24 14:15:53]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2016-06-24 14:16:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093713003/20001

[commit-bot: I haz the power, 2016-06-24 15:20:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 15:20:39]

Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[blundell, 2016-06-24 15:26:46]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2016-06-24 15:27:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 16:28:21]

Description was changed from

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
TBR=wangxianzhu
==========

to

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
TBR=wangxianzhu
==========

[commit-bot: I haz the power, 2016-06-24 16:28:22]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-24 16:34:41]

Description was changed from

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
TBR=wangxianzhu
==========

to

==========
Mark window-resize-background-image-non-fixed.html as needing manual rebaseline

r401697 changed this test from NeedsManualRebaseline to NeedsRebaseline.
However, after the rebaseline bot rebaselined it it's failing on Win7 and Win10
due to text diff (e.g.,
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7/builds/43...).
Hence, moving it back to NeedsManualRebaseline.

BUG=622898
TBR=wangxianzhu

Committed: https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b
Cr-Commit-Position: refs/heads/master@{#401876}
==========

[commit-bot: I haz the power, 2016-06-24 16:34:42]

Patchset 2 (id:??) landed as
https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b
Cr-Commit-Position: refs/heads/master@{#401876}

[Xianzhu, 2016-06-24 16:41:09]

On 2016/06/24 16:34:42, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b
> Cr-Commit-Position: refs/heads/master@{#401876}

Thanks for doing this.

However as the test is flaky, better way might be to mark it [ Pass Failure ]
because neither manual rebaseline nor auto rebaseline will work.

[blundell, 2016-06-27 07:21:57]

On 2016/06/24 16:41:09, Xianzhu wrote:
> On 2016/06/24 16:34:42, commit-bot: I haz the power wrote:
> > Patchset 2 (id:??) landed as
> > https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b
> > Cr-Commit-Position: refs/heads/master@{#401876}
> 
> Thanks for doing this.
> 
> However as the test is flaky, better way might be to mark it [ Pass Failure ]
> because neither manual rebaseline nor auto rebaseline will work.

Hi,

Thanks for the feedback -- I'm not familiar with Blink and wasn't really sure
which of the labels should be applied in which circumstances. Does "[ Pass
Failure ]" mean "passes on some platforms, fails on others"? If so then that's
definitely the right label.

[Xianzhu, 2016-06-27 16:44:48]

On 2016/06/27 07:21:57, blundell wrote:
> On 2016/06/24 16:41:09, Xianzhu wrote:
> > On 2016/06/24 16:34:42, commit-bot: I haz the power wrote:
> > > Patchset 2 (id:??) landed as
> > > https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b
> > > Cr-Commit-Position: refs/heads/master@{#401876}
> > 
> > Thanks for doing this.
> > 
> > However as the test is flaky, better way might be to mark it [ Pass Failure
]
> > because neither manual rebaseline nor auto rebaseline will work.
> 
> Hi,
> 
> Thanks for the feedback -- I'm not familiar with Blink and wasn't really sure
> which of the labels should be applied in which circumstances. Does "[ Pass
> Failure ]" mean "passes on some platforms, fails on others"? If so then that's
> definitely the right label.

[ Pass Failure ] means that the test sometimes passes and sometimes fails on all
platforms. If it fails on some platforms, we should mark the platform of failure
like this:
crbug.com/123456 [ Win ] some/test.html [ Failure ]

[blundell, 2016-07-04 08:09:30]

On 2016/06/27 16:44:48, Xianzhu wrote:
> On 2016/06/27 07:21:57, blundell wrote:
> > On 2016/06/24 16:41:09, Xianzhu wrote:
> > > On 2016/06/24 16:34:42, commit-bot: I haz the power wrote:
> > > > Patchset 2 (id:??) landed as
> > > > https://crrev.com/3b94286c06a31be7b85538f56e0dafd57731419b
> > > > Cr-Commit-Position: refs/heads/master@{#401876}
> > > 
> > > Thanks for doing this.
> > > 
> > > However as the test is flaky, better way might be to mark it [ Pass
Failure
> ]
> > > because neither manual rebaseline nor auto rebaseline will work.
> > 
> > Hi,
> > 
> > Thanks for the feedback -- I'm not familiar with Blink and wasn't really
sure
> > which of the labels should be applied in which circumstances. Does "[ Pass
> > Failure ]" mean "passes on some platforms, fails on others"? If so then
that's
> > definitely the right label.
> 
> [ Pass Failure ] means that the test sometimes passes and sometimes fails on
all
> platforms. If it fails on some platforms, we should mark the platform of
failure
> like this:
> crbug.com/123456 [ Win ] some/test.html [ Failure ]

Thanks.

https://codereview.chromium.org/2122623002/