Avoid to mask all the NetworkRpcException

Avoid to mask all the NetworkRpcException

If a malformed message is received and the test fails with a
NetworkRpcException the framework ignores it.
This is still a workaround, if the exception is no thrown from inside the test,
but from a non awaited Future, it will still pass the test.
To fix it definetly, it is required to find all the non awaited rpc requests
and await for them.

R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/0aa1f383d91d5b24cedf73ed4100dafcef46e817

[cbernaschina, 2016-06-23 17:52:40]

Description was changed from

==========
Avoid to mask all the NetworkRpcException

If a malformed message is received and the test fails with a
NetworkRpcException the framework ignores it.
This is still a workaround, if the exception is no thrown from inside the test,
but from a non awaited Future, it will still pass the test.
To fix it definetly, it is required to find all the non awaited rpc requests
and await for them.
==========

to

==========
Avoid to mask all the NetworkRpcException

If a malformed message is received and the test fails with a
NetworkRpcException the framework ignores it.
This is still a workaround, if the exception is no thrown from inside the test,
but from a non awaited Future, it will still pass the test.
To fix it definetly, it is required to find all the non awaited rpc requests
and await for them.
==========

[cbernaschina, 2016-06-23 17:52:40]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[Cutch, 2016-06-23 17:59:21]

https://codereview.chromium.org/2093703002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/2093703002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/test_helper.dart:313: // TODO: remove this
workaround.
Can you please expand on this comment and explain why checking for a non-null
stacktrace works around the issue?

[cbernaschina, 2016-06-23 18:27:24]

https://codereview.chromium.org/2093703002/diff/1/runtime/observatory/tests/s...
File runtime/observatory/tests/service/test_helper.dart (right):

https://codereview.chromium.org/2093703002/diff/1/runtime/observatory/tests/s...
runtime/observatory/tests/service/test_helper.dart:313: // TODO: remove this
workaround.
On 2016/06/23 17:59:20, Cutch wrote:
> Can you please expand on this comment and explain why checking for a non-null
> stacktrace works around the issue?

Done.

[Cutch, 2016-06-28 20:03:09]

lgtm

[cbernaschina, 2016-06-28 21:03:17]

Description was changed from

==========
Avoid to mask all the NetworkRpcException

If a malformed message is received and the test fails with a
NetworkRpcException the framework ignores it.
This is still a workaround, if the exception is no thrown from inside the test,
but from a non awaited Future, it will still pass the test.
To fix it definetly, it is required to find all the non awaited rpc requests
and await for them.
==========

to

==========
Avoid to mask all the NetworkRpcException

If a malformed message is received and the test fails with a
NetworkRpcException the framework ignores it.
This is still a workaround, if the exception is no thrown from inside the test,
but from a non awaited Future, it will still pass the test.
To fix it definetly, it is required to find all the non awaited rpc requests
and await for them.

R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0aa1f383d91d5b24cedf73ed4100dafcef46e817
==========

[cbernaschina, 2016-06-28 21:03:19]

Committed patchset #2 (id:20001) manually as
0aa1f383d91d5b24cedf73ed4100dafcef46e817 (presubmit successful).