Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2093663002: Cleanup some variable namings. (Closed)

Created:
4 years, 6 months ago by dsinclair
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup some variable namings. This CL cleans up some variable namings from the XFA_Element enum change. Committed: https://pdfium.googlesource.com/pdfium/+/41cb62ec84f8e8ca4ce8075fd4d825f8e22292a2

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -164 lines) Patch
M xfa/fxfa/app/xfa_ffnotify.cpp View 5 chunks +6 lines, -7 lines 0 comments Download
M xfa/fxfa/app/xfa_ffwidget.cpp View 2 chunks +8 lines, -10 lines 0 comments Download
M xfa/fxfa/parser/cxfa_widgetdata.cpp View 6 chunks +6 lines, -8 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datadescription_imp.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.h View 1 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_document_datamerger_imp.cpp View 10 chunks +17 lines, -17 lines 0 comments Download
M xfa/fxfa/parser/xfa_document_serialize.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_itemlayout.cpp View 3 chunks +9 lines, -11 lines 0 comments Download
M xfa/fxfa/parser/xfa_layout_pagemgr_new.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M xfa/fxfa/parser/xfa_object.h View 1 7 chunks +12 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_object_imp.cpp View 1 24 chunks +47 lines, -54 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_layoutpseudomodel.cpp View 1 2 chunks +6 lines, -12 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_nodehelper.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M xfa/fxfa/parser/xfa_utils_imp.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
dsinclair
PTAL.
4 years, 6 months ago (2016-06-23 14:37:16 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/2093663002/diff/1/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp File xfa/fxfa/parser/xfa_document_datamerger_imp.cpp (right): https://codereview.chromium.org/2093663002/diff/1/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp#newcode468 xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:468: XFA_Element eType, Fix the header too. https://codereview.chromium.org/2093663002/diff/1/xfa/fxfa/parser/xfa_object_imp.cpp File ...
4 years, 6 months ago (2016-06-23 15:01:23 UTC) #3
dsinclair
https://codereview.chromium.org/2093663002/diff/1/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp File xfa/fxfa/parser/xfa_document_datamerger_imp.cpp (right): https://codereview.chromium.org/2093663002/diff/1/xfa/fxfa/parser/xfa_document_datamerger_imp.cpp#newcode468 xfa/fxfa/parser/xfa_document_datamerger_imp.cpp:468: XFA_Element eType, On 2016/06/23 15:01:23, Lei Zhang (Slow) wrote: ...
4 years, 6 months ago (2016-06-23 15:57:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093663002/20001
4 years, 6 months ago (2016-06-23 15:57:38 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 16:20:39 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/41cb62ec84f8e8ca4ce8075fd4d825f8e222...

Powered by Google App Engine
This is Rietveld 408576698