Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2093613002: Simplify source position calculation. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
jgruber
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Simplify source position calculation. R=jgruber@chromium.org BUG=v8:5117 Committed: https://crrev.com/2a5a8fde1c9109502f23f600725498e2df10b2bd Cr-Commit-Position: refs/heads/master@{#37211}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M src/objects.cc View 3 chunks +15 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
4 years, 6 months ago (2016-06-23 09:27:47 UTC) #1
jgruber
Nice, lgtm.
4 years, 6 months ago (2016-06-23 09:48:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093613002/1
4 years, 6 months ago (2016-06-23 10:51:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 11:16:25 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 11:17:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a5a8fde1c9109502f23f600725498e2df10b2bd
Cr-Commit-Position: refs/heads/master@{#37211}

Powered by Google App Engine
This is Rietveld 408576698