luci-py: Making __file__ usage unicode safe.

luci-py: Making __file__ usage unicode safe.

In luci-py, all paths should be unicode.

__file__ is a str object in the file system's encoding, hence you need to use
`__file__.decode(sys.getfilesystemencoding())` to convert it into unicode.

Fixes #264.

Committed: https://github.com/luci/luci-py/commit/35ec08d6007a823bf39a5095c8bc98a6865b8efd

[mithro, 2016-06-23 06:13:49]

tansell@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2016-06-23 13:09:54]

lgtm

https://codereview.chromium.org/2093593002/diff/1/client/utils/zip_package.py
File client/utils/zip_package.py (right):

https://codereview.chromium.org/2093593002/diff/1/client/utils/zip_package.py...
client/utils/zip_package.py:36: 
add another empty line above.

https://codereview.chromium.org/2093593002/diff/1/client/utils/zip_package.py...
client/utils/zip_package.py:45: sys.path_hooks[i] = zipimporter_unicode
sadness

[mithro, 2016-06-24 03:22:42]

https://codereview.chromium.org/2093593002/diff/1/client/utils/zip_package.py
File client/utils/zip_package.py (right):

https://codereview.chromium.org/2093593002/diff/1/client/utils/zip_package.py...
client/utils/zip_package.py:36: 
On 2016/06/23 13:09:54, M-A Ruel OOO up to July 10th wrote:
> add another empty line above.

Done.

https://codereview.chromium.org/2093593002/diff/1/client/utils/zip_package.py...
client/utils/zip_package.py:45: sys.path_hooks[i] = zipimporter_unicode
On 2016/06/23 13:09:54, M-A Ruel OOO up to July 10th wrote:
> sadness

Yeah :(

It works properly in Python 3...

[mithro, 2016-06-24 03:22:51]

The CQ bit was checked by tansell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 03:22:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093593002/20001

[mithro, 2016-06-24 03:23:38]

I also create https://github.com/luci/luci-py/issues/265 for us to discuss how
to prevent issues like these creeping back into the code.

[commit-bot: I haz the power, 2016-06-24 03:27:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 03:27:26]

Dry run: This issue passed the CQ dry run.

[mithro, 2016-06-24 05:31:33]

The CQ bit was checked by tansell@chromium.org

[mithro, 2016-06-24 05:31:34]

The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/2093593002/#ps20001
(title: "Small fixes.")

[commit-bot: I haz the power, 2016-06-24 05:31:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093593002/20001

[commit-bot: I haz the power, 2016-06-24 05:34:34]

Description was changed from

==========
luci-py: Making __file__ usage unicode safe.

In luci-py, all paths should be unicode.

__file__ is a str object in the file system's encoding, hence you need to use
`__file__.decode(sys.getfilesystemencoding())` to convert it into unicode.

Fixes #264.
==========

to

==========
luci-py: Making __file__ usage unicode safe.

In luci-py, all paths should be unicode.

__file__ is a str object in the file system's encoding, hence you need to use
`__file__.decode(sys.getfilesystemencoding())` to convert it into unicode.

Fixes #264.

Committed:
https://github.com/luci/luci-py/commit/35ec08d6007a823bf39a5095c8bc98a6865b8efd
==========

[commit-bot: I haz the power, 2016-06-24 05:34:35]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-py/commit/35ec08d6007a823bf39a5095c8bc98a6865b8efd