scripts/common/chromium_utils.py - Issue 2093583002: Remove the require_dbconfig arg.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/common/chromium_utils.py

Issue 2093583002: Remove the require_dbconfig arg. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@changeHorizon

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: scripts/common/chromium_utils.py

diff --git a/scripts/common/chromium_utils.py b/scripts/common/chromium_utils.py

index b4d30834c6b8853aa6b26d078d71ea4f39e540dd..7cf9e865b44fd56057e9a1801b867e72cdaf23df 100644

--- a/scripts/common/chromium_utils.py

+++ b/scripts/common/chromium_utils.py

@@ -1898,7 +1898,7 @@ def FileExclusions():

return all_platforms

-def DatabaseSetup(buildmaster_config, require_dbconfig=False):

+def DatabaseSetup(buildmaster_config):

"""Configure the database settings for the buildbot master."""

# By default nothing is ever deleted from the database. We set a

@@ -1916,8 +1916,6 @@ def DatabaseSetup(buildmaster_config, require_dbconfig=False):

buildmaster_config['db_url'] = 'postgresql://%s:%s@%s/%s' % (

values['username'], values['password'],

values.get('hostname', 'localhost'), values['dbname'])

- else:

- assert not require_dbconfig

def ReadBuildersFile(builders_path):

« no previous file with comments | « no previous file | no next file » | no next file with comments »