Debug shortcut to toggle touch view

Debug shortcut to toggle touch view

Cleanup

BUG=None

Committed: https://crrev.com/1d55f40b757a0eab6dba17a4fe0048d687fb3bbe
Cr-Commit-Position: refs/heads/master@{#401831}

[oshima, 2016-06-23 06:05:49]

Patchset #1 (id:1) has been deleted

[oshima, 2016-06-23 06:06:00]

oshima@chromium.org changed reviewers:
+ skuhne@chromium.org

[oshima, 2016-06-23 06:06:01]

https://codereview.chromium.org/2093573003/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_table.cc (left):

https://codereview.chromium.org/2093573003/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_table.cc:261: DEBUG_ADD_REMOVE_DISPLAY},
this is intentional

https://codereview.chromium.org/2093573003/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_table.cc:273: SWAP_PRIMARY_DISPLAY},
this is intentional

[oshima, 2016-06-23 06:06:07]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 06:06:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093573003/20001

[commit-bot: I haz the power, 2016-06-23 06:41:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-23 06:41:54]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mr4D (OOO till 08-26), 2016-06-23 19:52:48]

lgtm

https://codereview.chromium.org/2093573003/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/2093573003/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_table.cc:297: ui::EF_SHIFT_DOWN |
ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN,
Just wondering - these are also for debuigging and they use the same keys -
maybe you want to replace those also with kDebugModifier?

Same above

[oshima, 2016-06-23 23:38:46]

Patchset #2 (id:40001) has been deleted

[oshima, 2016-06-23 23:38:52]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-23 23:39:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093573003/60001

[oshima, 2016-06-23 23:39:35]

https://codereview.chromium.org/2093573003/diff/20001/ash/accelerators/accele...
File ash/accelerators/accelerator_table.cc (right):

https://codereview.chromium.org/2093573003/diff/20001/ash/accelerators/accele...
ash/accelerators/accelerator_table.cc:297: ui::EF_SHIFT_DOWN |
ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN,
On 2016/06/23 19:52:48, Mr4D wrote:
> Just wondering - these are also for debuigging and they use the same keys -
> maybe you want to replace those also with kDebugModifier?
> 
> Same above
Not sure why I didn't do that. Probably sleeping. Done.

Thanks!

https://codereview.chromium.org/2093573003/diff/20001/ash/wm/maximize_mode/ma...
File ash/wm/maximize_mode/maximize_mode_controller.cc (right):

https://codereview.chromium.org/2093573003/diff/20001/ash/wm/maximize_mode/ma...
ash/wm/maximize_mode/maximize_mode_controller.cc:148: #endif
tuns out that this isn't necessary. reverted.

[commit-bot: I haz the power, 2016-06-24 01:15:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 01:15:49]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-06-24 07:08:52]

The CQ bit was checked by oshima@chromium.org

[oshima, 2016-06-24 07:08:52]

The patchset sent to the CQ was uploaded after l-g-t-m from skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2093573003/#ps60001
(title: "addressed comments. revert unnecesary change")

[commit-bot: I haz the power, 2016-06-24 07:08:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093573003/60001

[commit-bot: I haz the power, 2016-06-24 07:14:53]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-06-24 07:17:24]

Description was changed from

==========
Debug shortcut to toggle touch view

Cleanup

BUG=None
==========

to

==========
Debug shortcut to toggle touch view

Cleanup

BUG=None

Committed: https://crrev.com/1d55f40b757a0eab6dba17a4fe0048d687fb3bbe
Cr-Commit-Position: refs/heads/master@{#401831}
==========

[commit-bot: I haz the power, 2016-06-24 07:17:25]

Patchset 2 (id:??) landed as
https://crrev.com/1d55f40b757a0eab6dba17a4fe0048d687fb3bbe
Cr-Commit-Position: refs/heads/master@{#401831}