Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: components/arc/BUILD.gn

Issue 2093563007: Add a floating close button for arc custom notification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move arc_service etc into arc_base target, update //ui/arc and add to .gn Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/arc.gypi ('k') | components/arc/arc_bridge_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/arc/BUILD.gn
diff --git a/components/arc/BUILD.gn b/components/arc/BUILD.gn
index fa0aebbef3f47c47cc41464546a208e1712c8dd9..18051cc9acf495050610685d04ed69865c5fe67f 100644
--- a/components/arc/BUILD.gn
+++ b/components/arc/BUILD.gn
@@ -9,18 +9,12 @@ static_library("arc") {
sources = [
"arc_bridge_bootstrap.cc",
"arc_bridge_bootstrap.h",
- "arc_bridge_service.cc",
- "arc_bridge_service.h",
"arc_bridge_service_impl.cc",
"arc_bridge_service_impl.h",
- "arc_service.cc",
- "arc_service.h",
"arc_service_manager.cc",
"arc_service_manager.h",
"audio/arc_audio_bridge.cc",
"audio/arc_audio_bridge.h",
- "bitmap/bitmap_type_converters.cc",
- "bitmap/bitmap_type_converters.h",
"bluetooth/arc_bluetooth_bridge.cc",
"bluetooth/arc_bluetooth_bridge.h",
"bluetooth/bluetooth_type_converters.cc",
@@ -65,6 +59,7 @@ static_library("arc") {
]
deps = [
+ ":arc_base",
"//ash:ash",
"//base",
"//chromeos",
@@ -97,6 +92,27 @@ static_library("arc") {
]
}
+static_library("arc_base") {
+ sources = [
+ "arc_bridge_service.cc",
+ "arc_bridge_service.h",
+ "arc_service.cc",
+ "arc_service.h",
+ "bitmap/bitmap_type_converters.cc",
+ "bitmap/bitmap_type_converters.h",
Luis Héctor Chávez 2016/06/27 22:07:11 These two files don't seem to be very base-y. Can
xiyuan 2016/06/27 22:24:07 Added an arc_bitmap target for them.
+ ]
+
+ deps = [
+ "//base",
+ "//chromeos",
+ "//skia",
+ ]
+
+ public_deps = [
+ ":arc_bindings",
+ ]
+}
+
mojom("arc_bindings") {
sources = [
"common/app.mojom",
@@ -149,6 +165,7 @@ static_library("arc_test_support") {
deps = [
":arc",
+ ":arc_base",
":arc_bindings",
"//base",
"//mojo/common:common_base",
« no previous file with comments | « components/arc.gypi ('k') | components/arc/arc_bridge_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698