Chromium Code Reviews
DescriptionRevert of Extract media/capture/capture_unittests from media_unittests (patchset #4 id:120001 of https://codereview.chromium.org/2087683002/ )
Reason for revert:
Broke Win x64 bot https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1849
FAILED: audio_unittests.exe audio_unittests.exe.pdb
C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True audio_unittests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:audio_unittests.exe @audio_unittests.exe.rsp" 1 mt.exe rc.exe "obj\media\audio_unittests.audio_unittests.exe.intermediate.manifest" obj\media\audio_unittests.audio_unittests.exe.generated.manifest ..\..\build\win\compatibility.manifest
media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external symbol CLSID_DxDiagProvider referenced in function "public: static bool __cdecl media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)" (?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z)
media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external symbol IID_IDxDiagProvider referenced in function "public: static bool __cdecl media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)" (?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z)
audio_unittests.exe : fatal error LNK1120: 2 unresolved externals
Original issue's description:
> Extract media/capture/capture_unittests from media_unittests
>
> This CL:
> - extracts capture_unittests out of media_unittests.
> - adds it to all testing/buildbot/*.json where appropriate,
> i.e. where there is media_unittests.
> - adds the necessary .isolate and _apk.isolate.
>
> BUG=618718
> TEST= No new code added, all bots running capture_unittests
> and being happy with it.¯
>
> TBR=miu@chromium.org
>
> Committed: https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d
> Cr-Commit-Position: refs/heads/master@{#401692}
TBR=xhwang@chromium.org,maruel@chromium.org,brettw@chromium.org,miu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=618718
Committed: https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df
Cr-Commit-Position: refs/heads/master@{#401714}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||