Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2093563004: Revert of Extract media/capture/capture_unittests from media_unittests (Closed)

Created:
4 years, 6 months ago by mcasas
Modified:
4 years, 6 months ago
Reviewers:
brettw, xhwang, M-A Ruel, miu
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Extract media/capture/capture_unittests from media_unittests (patchset #4 id:120001 of https://codereview.chromium.org/2087683002/ ) Reason for revert: Broke Win x64 bot https://build.chromium.org/p/chromium/builders/Win%20x64/builds/1849 FAILED: audio_unittests.exe audio_unittests.exe.pdb C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-with-manifests environment.x64 True audio_unittests.exe "C:\b\depot_tools\python276_bin\python.exe gyp-win-tool link-wrapper environment.x64 False link.exe /nologo /OUT:audio_unittests.exe @audio_unittests.exe.rsp" 1 mt.exe rc.exe "obj\media\audio_unittests.audio_unittests.exe.intermediate.manifest" obj\media\audio_unittests.audio_unittests.exe.generated.manifest ..\..\build\win\compatibility.manifest media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external symbol CLSID_DxDiagProvider referenced in function "public: static bool __cdecl media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)" (?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z) media.lib(media.core_audio_util_win.obj) : error LNK2019: unresolved external symbol IID_IDxDiagProvider referenced in function "public: static bool __cdecl media::CoreAudioUtil::GetDxDiagDetails(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > *)" (?GetDxDiagDetails@CoreAudioUtil@media@@SA_NPEAV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@0@Z) audio_unittests.exe : fatal error LNK1120: 2 unresolved externals Original issue's description: > Extract media/capture/capture_unittests from media_unittests > > This CL: > - extracts capture_unittests out of media_unittests. > - adds it to all testing/buildbot/*.json where appropriate, > i.e. where there is media_unittests. > - adds the necessary .isolate and _apk.isolate. > > BUG=618718 > TEST= No new code added, all bots running capture_unittests > and being happy with it.¯ > > TBR=miu@chromium.org > > Committed: https://crrev.com/13b4123d553a41899acebba9020b99ace0f2472d > Cr-Commit-Position: refs/heads/master@{#401692} TBR=xhwang@chromium.org,maruel@chromium.org,brettw@chromium.org,miu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=618718 Committed: https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df Cr-Commit-Position: refs/heads/master@{#401714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -630 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M build/all.gyp View 11 chunks +0 lines, -11 lines 0 comments Download
M media/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download
M media/base/run_all_unittests.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M media/capture/BUILD.gn View 2 chunks +4 lines, -9 lines 0 comments Download
M media/capture/capture.gyp View 3 chunks +10 lines, -89 lines 0 comments Download
D media/capture/capture_unittests.isolate View 1 chunk +0 lines, -62 lines 0 comments Download
D media/capture/capture_unittests_apk.isolate View 1 chunk +0 lines, -18 lines 0 comments Download
M media/capture/video/android/photo_capabilities.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/media.gyp View 3 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.android.json View 10 chunks +0 lines, -50 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 39 chunks +0 lines, -213 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 6 chunks +0 lines, -41 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +0 lines, -18 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 8 chunks +0 lines, -29 lines 0 comments Download
M testing/buildbot/chromium.webrtc.json View 3 chunks +0 lines, -3 lines 0 comments Download
M testing/buildbot/chromium.webrtc.fyi.json View 7 chunks +0 lines, -7 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +0 lines, -24 lines 0 comments Download
M testing/buildbot/chromium_memory_trybot.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/client.v8.fyi.json View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
M testing/buildbot/tryserver.v8.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
mcasas
Created Revert of Extract media/capture/capture_unittests from media_unittests
4 years, 6 months ago (2016-06-23 21:15:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093563004/1
4 years, 6 months ago (2016-06-23 21:16:51 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 21:18:03 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 21:19:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5de80c184c4e0f4460809d8fb52253b087a0e6df
Cr-Commit-Position: refs/heads/master@{#401714}

Powered by Google App Engine
This is Rietveld 408576698