Disable the Context Menu in the tab-modal signin dialog.

Disable the Context Menu in the tab-modal signin dialog.

This prevents weird behaviors such as opening links in different profiles and unusable "view source" and "print" buttons.

BUG=622225, 614680, 602594
TEST=
1. Open the User Menu and click "sign in to Chrome"
2. In the sign in flow and the sync confirmation dialog, right-clicking to display the context menu shouldn't work.

Committed: https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e
Cr-Commit-Position: refs/heads/master@{#402235}

[anthonyvd, 2016-06-23 17:43:01]

Description was changed from

==========
Disable the Context Menu in the tab-modal signin dialog.

BUG=622225,614680,602594
==========

to

==========
Disable the Context Menu in the tab-modal signin dialog.

This prevents weird behaviors such as opening links in different profiles and
unusable "view source" and "print" buttons.

BUG=622225,614680,602594
TEST=
1. Open the User Menu and click "sign in to Chrome"
2. In the sign in flow and the sync confirmation dialog, right-clicking to
display the context menu shouldn't work.
==========

[anthonyvd, 2016-06-23 17:43:12]

anthonyvd@chromium.org changed reviewers:
+ sky@chromium.org

[anthonyvd, 2016-06-23 17:43:13]

Hi sky@, can you please take a look at this small change?

Thanks!

[sky, 2016-06-23 19:13:24]

LGTM

https://codereview.chromium.org/2093563003/diff/1/chrome/browser/ui/signin_vi...
File chrome/browser/ui/signin_view_controller_delegate.cc (right):

https://codereview.chromium.org/2093563003/diff/1/chrome/browser/ui/signin_vi...
chrome/browser/ui/signin_view_controller_delegate.cc:71: bool
SigninViewControllerDelegate::HandleContextMenu(
make order match position in header.

[anthonyvd, 2016-06-27 15:28:16]

https://codereview.chromium.org/2093563003/diff/1/chrome/browser/ui/signin_vi...
File chrome/browser/ui/signin_view_controller_delegate.cc (right):

https://codereview.chromium.org/2093563003/diff/1/chrome/browser/ui/signin_vi...
chrome/browser/ui/signin_view_controller_delegate.cc:71: bool
SigninViewControllerDelegate::HandleContextMenu(
On 2016/06/23 at 19:13:24, sky wrote:
> make order match position in header.

Good catch, most of the file was out of order. Done.

[anthonyvd, 2016-06-27 18:35:18]

The CQ bit was checked by anthonyvd@chromium.org

[anthonyvd, 2016-06-27 18:35:18]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2093563003/#ps20001
(title: "Reorder functions to match header file order.")

[commit-bot: I haz the power, 2016-06-27 18:36:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 18:41:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-27 18:43:57]

Description was changed from

==========
Disable the Context Menu in the tab-modal signin dialog.

This prevents weird behaviors such as opening links in different profiles and
unusable "view source" and "print" buttons.

BUG=622225,614680,602594
TEST=
1. Open the User Menu and click "sign in to Chrome"
2. In the sign in flow and the sync confirmation dialog, right-clicking to
display the context menu shouldn't work.
==========

to

==========
Disable the Context Menu in the tab-modal signin dialog.

This prevents weird behaviors such as opening links in different profiles and
unusable "view source" and "print" buttons.

BUG=622225,614680,602594
TEST=
1. Open the User Menu and click "sign in to Chrome"
2. In the sign in flow and the sync confirmation dialog, right-clicking to
display the context menu shouldn't work.

Committed: https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e
Cr-Commit-Position: refs/heads/master@{#402235}
==========

[commit-bot: I haz the power, 2016-06-27 18:43:58]

Patchset 2 (id:??) landed as
https://crrev.com/dc9e2a6739335b0ad0ed16b8ffd08a68a96e6b2e
Cr-Commit-Position: refs/heads/master@{#402235}