[Mac/iOS/GN] Remove bad -Wno-deprecated-declarations from //third_party/google_toolbox_for_mac publ…

third_party/google_toolbox_for_mac/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-config("google_toolbox_for_mac_config") {
+config("google_toolbox_for_mac_public_config") {
   include_dirs = [
     ".",
     "src",
     "src/AppKit",
     "src/DebugUtils",
     "src/Foundation",
   ]
-
-  # TODO(crbug.com/569158): Suppresses warnings that are treated as errors
-  # when minimum iOS version support is increased to iOS 9 and up.
-  # This should be removed once all deprecation violations have been fixed.
-  cflags = [ "-Wno-deprecated-declarations" ]
 }
 
 component("google_toolbox_for_mac") {
   sources = [
     "src/DebugUtils/GTMMethodCheck.h",
     "src/DebugUtils/GTMMethodCheck.m",
     "src/Foundation/GTMLightweightProxy.h",
     "src/Foundation/GTMLightweightProxy.m",
     "src/Foundation/GTMLogger.h",
     "src/Foundation/GTMLogger.m",
     "src/Foundation/GTMNSDictionary+URLArguments.h",
     "src/Foundation/GTMNSDictionary+URLArguments.m",
     "src/Foundation/GTMNSObject+KeyValueObserving.h",
     "src/Foundation/GTMNSObject+KeyValueObserving.m",
     "src/Foundation/GTMNSString+HTML.h",
     "src/Foundation/GTMNSString+HTML.m",
     "src/Foundation/GTMNSString+URLArguments.h",
     "src/Foundation/GTMNSString+URLArguments.m",
     "src/Foundation/GTMRegex.h",
     "src/Foundation/GTMRegex.m",
     "src/Foundation/GTMStringEncoding.h",
     "src/Foundation/GTMStringEncoding.m",
   ]
 
   configs -= [ "//build/config/compiler:chromium_code" ]
-  configs += [
-    ":google_toolbox_for_mac_config",
-    "//build/config/compiler:no_chromium_code",
-  ]
-  public_configs = [ ":google_toolbox_for_mac_config" ]
+  configs += [ "//build/config/compiler:no_chromium_code" ]
+  public_configs = [ ":google_toolbox_for_mac_public_config" ]
 
   if (!is_ios) {
     sources += [
       "src/AddressBook/GTMABAddressBook.h",
       "src/AddressBook/GTMABAddressBook.m",
       "src/AppKit/GTMCarbonEvent.h",
       "src/AppKit/GTMCarbonEvent.m",
       "src/AppKit/GTMDelegatingTableColumn.h",
       "src/AppKit/GTMDelegatingTableColumn.m",
       "src/AppKit/GTMFadeTruncatingTextFieldCell.h",
@@ skipping 127 matching lines @@
     sources += [
       "src/iPhone/GTMFadeTruncatingLabel.h",
       "src/iPhone/GTMFadeTruncatingLabel.m",
       "src/iPhone/GTMRoundedRectPath.h",
       "src/iPhone/GTMRoundedRectPath.m",
       "src/iPhone/GTMUIImage+Resize.h",
       "src/iPhone/GTMUIImage+Resize.m",
       "src/iPhone/GTMUILocalizer.h",
       "src/iPhone/GTMUILocalizer.m",
     ]
+
+    # TODO(crbug.com/569158): Suppresses warnings that are treated as errors
+    # when minimum iOS version support is increased to iOS 9 and up.
+    # This should be removed once all deprecation violations have been fixed.
+    cflags = [ "-Wno-deprecated-declarations" ]

[Nico, 2016/06/24 19:17:40]

oh, fyi, in general putting -Wno-foo flags in cflags instead of a config doesn't
work. Since this target removes chromium_code and adds no_chromium_code,
no_chromium_code is pretty late in the config list, and its flags get added
before the cflags here. no_chromium_code does contain -Wall, so -Wall will
appear after -Wno-foo, and if foo is in -Wall then the -Wall will reenable the
warning that -Wno-foo disabled. In this case, Wdeprecated-declarations
apparently isn't in -Wall, which might be why this works. (Or the flag isn't
needed anymore?)

[Robert Sesek, 2016/06/24 19:59:25]

Hm. It is necessary on iOS and not on Mac (see ps1 failures). Should I switch
these to a config for iOS? It currently is working as intended.

   }
 
   if (is_component_build) {
     # GTM is third-party code, so we don't want to add _EXPORT
     # annotations to it, so build it without -fvisibility=hidden
     # (else the interface class symbols will be hidden in a 64bit
     # build). Only do this in a component build, so that the shipping
     # chrome binary doesn't end up with unnecessarily exported
     # symbols.
     configs -= [ "//build/config/gcc:symbol_visibility_hidden" ]
     configs += [ "//build/config/gcc:symbol_visibility_default" ]
   }
 }