Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2093543002: Do not snapshot error pages (Closed)

Created:
4 years, 6 months ago by jianli
Modified:
4 years, 6 months ago
Reviewers:
dewittj
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not snapshot error pages BUG=615578 TEST=new test added Committed: https://crrev.com/727396f4c3b07005e59b5912f9a9e3fd46817577 Cr-Commit-Position: refs/heads/master@{#401503}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -7 lines) Patch
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc View 6 chunks +30 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jianli
4 years, 6 months ago (2016-06-23 00:45:39 UTC) #2
dewittj
lgtm
4 years, 6 months ago (2016-06-23 00:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2093543002/1
4 years, 6 months ago (2016-06-23 01:25:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-23 01:30:51 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-23 01:35:14 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/727396f4c3b07005e59b5912f9a9e3fd46817577
Cr-Commit-Position: refs/heads/master@{#401503}

Powered by Google App Engine
This is Rietveld 408576698