Turn off Task Manager should not break the build on Linux

chrome/browser/ui/browser_commands.cc

Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index de82e31324840c45892150c346eb4fc338e64f30..2c28aa1de70655b2bf5d5f9dbbee19b8a564558b 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -1009,6 +1009,10 @@ void ToggleDevToolsWindow(Browser* browser, DevToolsToggleAction action) {
 }
 
 bool CanOpenTaskManager() {
+#if !defined(ENABLE_TASK_MANAGER)
+  return false;
+#endif  // defined(ENABLE_TASK_MANAGER)

[Peter Kasting, 2014/03/25 20:48:43]

You can't do this; this will trigger an unreachable code warning in MSVC if
ENABLE_TASK_MANAGER is not defined, once that warning is turned on.

Instead of the #endif you have, you need to wrap the subsequent code in an
#else.

Nit: Don't bother with the EOL comments here and below, these #ifs are short and
the comments just add noise.

+
 #if defined(OS_WIN)
   // In metro we can't display the task manager, as it is a native window.
   return !win8::IsSingleWindowMetroMode();
@@ -1018,8 +1022,12 @@ bool CanOpenTaskManager() {
 }
 
 void OpenTaskManager(Browser* browser) {
+#if defined(ENABLE_TASK_MANAGER)
   content::RecordAction(UserMetricsAction("TaskManager"));
   chrome::ShowTaskManager(browser);
+#else
+  NOTREACHED();
+#endif  // defined(ENABLE_TASK_MANAGER)
 }
 
 void OpenFeedbackDialog(Browser* browser) {