Clean up handling of autosizing state changes.

Source/core/frame/FrameView.cpp

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999 Lars Knoll <knoll@kde.org>
  *                     1999 Antti Koivisto <koivisto@kde.org>
  *                     2000 Dirk Mueller <mueller@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
@@ skipping 352 matching lines @@
     renderer->repaintRectangle(repaintRect);
 }
 
 void FrameView::setFrameRect(const IntRect& newRect)
 {
     IntRect oldRect = frameRect();
     if (newRect == oldRect)
         return;
 
     // Autosized font sizes depend on the width of the viewing area.
+    bool mainFrameWidthChanged = false;
     if (newRect.width() != oldRect.width()) {
-        if (isMainFrame() && m_frame->settings()->textAutosizingEnabled()) {
-            for (LocalFrame* frame = m_frame.get(); frame; frame = frame->tree().traverseNext()) {
-                if (TextAutosizer* textAutosizer = frame->document()->textAutosizer())
-                    textAutosizer->recalculateMultipliers();
+        if (isMainFrame()) {
+            mainFrameWidthChanged = true;
+            if (m_frame->settings()->textAutosizingEnabled()) {

[timvolodine, 2014/03/25 13:08:14]

should this be higher up, i.e. if (isMainFrame() &&
m_frame->settings()->textAuto...). Otherwise the code behind
mainFrameWidthChanded later in the function can be called even if
textAutosizingEnabled() is false?

[skobes, 2014/03/25 18:25:26]

Done.

It doesn't really matter since FTA does nothing when it is disabled, but I guess
it could save a couple of cycles.  Also renamed the variable to reflect the new
semantics.

+                for (LocalFrame* frame = m_frame.get(); frame; frame = frame->tree().traverseNext()) {
+                    if (TextAutosizer* textAutosizer = frame->document()->textAutosizer())
+                        textAutosizer->recalculateMultipliers();
+                }
             }
         }
     }
 
     ScrollView::setFrameRect(newRect);
 
     updateScrollableAreaSet();
 
+    if (mainFrameWidthChanged) {
+        // This needs to be after the call to ScrollView::setFrameRect, because it reads the new width.
+        if (FastTextAutosizer* textAutosizer = m_frame->document()->fastTextAutosizer())
+            textAutosizer->updatePageInfoInAllFrames();
+    }
+
     if (RenderView* renderView = this->renderView()) {
         if (renderView->usesCompositing())
             renderView->compositor()->frameViewDidChangeSize();
     }
 
     viewportConstrainedVisibleContentSizeChanged(newRect.width() != oldRect.width(), newRect.height() != oldRect.height());
 }
 
 bool FrameView::scheduleAnimation()
 {
@@ skipping 1342 matching lines @@
         IntRect repaintRect = r;
         repaintRect.move(-scrollOffset());
         m_trackedRepaintRects.append(repaintRect);
     }
 
     ScrollView::repaintContentRectangle(r);
 }
 
 void FrameView::contentsResized()
 {
+    if (isMainFrame()) {
+        if (FastTextAutosizer* textAutosizer = m_frame->document()->fastTextAutosizer())
+            textAutosizer->updatePageInfoInAllFrames();
+    }
+
     ScrollView::contentsResized();
     setNeedsLayout();
 }
 
 void FrameView::scrollbarExistenceDidChange()
 {
     // We check to make sure the view is attached to a frame() as this method can
     // be triggered before the view is attached by LocalFrame::createView(...) setting
     // various values such as setScrollBarModes(...) for example.  An ASSERT is
     // triggered when a view is layout before being attached to a frame().
@@ skipping 1461 matching lines @@
 void FrameView::willRemoveScrollbar(Scrollbar* scrollbar, ScrollbarOrientation orientation)
 {
     ScrollableArea::willRemoveScrollbar(scrollbar, orientation);
     if (AXObjectCache* cache = axObjectCache()) {
         cache->remove(scrollbar);
         cache->handleScrollbarUpdate(this);
     }
 }
 
 } // namespace WebCore