LayoutTests/fast/text-autosizing/font-scale-factor-change-expected.html - Issue 209353003: Clean up handling of autosizing state changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text-autosizing/font-scale-factor-change-expected.html

Issue 209353003: Clean up handling of autosizing state changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@crap_base

Patch Set: Address review comments. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta name="viewport" content="width=320">

	5 <style>

	6 html { font-size: 16px; }

	7 body { width: 320px; margin: 0; overflow-y: hidden; }

	8 </style>

	9

	10 </head>

	11 <body>

	12 <div style="font-size: 2rem">
	timvolodine 2014/03/25 13:08:14 so the 2 is due to setFontScaleFactor(2)? I unders so the 2 is due to setFontScaleFactor(2)? I understand there is no actual autosizing (i.e. multiplier 320/320=1) involved here? if that's the case maybe add something to the explaining text. skobes 2014/03/25 18:25:26 I'm not following what you mean here. Autosizing Show quoted text On 2014/03/25 13:08:14, timvolodine wrote: > so the 2 is due to setFontScaleFactor(2)? I understand there is no actual > autosizing (i.e. multiplier 320/320=1) involved here? if that's the case maybe > add something to the explaining text. I'm not following what you mean here. Autosizing is how the font scale factor is implemented. timvolodine 2014/03/26 12:33:00 What I meant is that you are testing the accessibi Show quoted text On 2014/03/25 18:25:26, skobes wrote: > On 2014/03/25 13:08:14, timvolodine wrote: > > so the 2 is due to setFontScaleFactor(2)? I understand there is no actual > > autosizing (i.e. multiplier 320/320=1) involved here? if that's the case maybe > > add something to the explaining text. > > I'm not following what you mean here. Autosizing is how the font scale factor > is implemented. What I meant is that you are testing the accessibility setting only. Usually we use width=800 for autosizing resulting in 800/320=2.5 multiplier. You seem to use width=320, so if there was no call to setFontScaleFactor(2) the text would not be autosized. In that this test differs from the others and that is what I was trying to clarify. But this is just a nit ;), as it does not impact code or functionality.
	13 This test verifies that the page updates correctly after a dynamic change to the font scale factor.

	14

	15 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur sapien sapien , tempus id egestas a, consectetur et felis. Ut pharetra mi eget lectus laoreet rutrum. Mauris tellus odio, egestas vitae sodales in, vehicula eget ante. Pellen tesque id egestas arcu. Quisque tellus quam, rhoncus ac elementum vel, volutpat vel felis. Aliquam ut leo dolor, eget egestas tellus. Nunc ut velit gravida nisl fringilla rutrum eget at arcu. Vivamus et pretium mauris.

	16 </div>

	17 </body>

	18 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/fast/text-autosizing/font-scale-factor-change.html ('k') | Source/core/dom/Document.cpp » ('j') | Source/core/frame/FrameView.cpp » ('J')