LayoutTests/fast/text-autosizing/font-scale-factor-change.html - Issue 209353003: Clean up handling of autosizing state changes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/text-autosizing/font-scale-factor-change.html

Issue 209353003: Clean up handling of autosizing state changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@crap_base

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | LayoutTests/fast/text-autosizing/font-scale-factor-change-expected.html » ('j') | LayoutTests/fast/text-autosizing/font-scale-factor-change-expected.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <meta name="viewport" content="width=320">

	5 <style>

	6 html { font-size: 16px; }

	7 body { width: 320px; margin: 0; overflow-y: hidden; }

	8 </style>

	9 <script src="resources/autosizingTest.js"></script>

	10 </head>

	11 <body>

	12 <div>

	13 Lorem ipsum dolor sit amet, consectetur adipiscing elit. Curabitur sapien sapien , tempus id egestas a, consectetur et felis. Ut pharetra mi eget lectus laoreet rutrum. Mauris tellus odio, egestas vitae sodales in, vehicula eget ante. Pellen tesque id egestas arcu. Quisque tellus quam, rhoncus ac elementum vel, volutpat vel felis. Aliquam ut leo dolor, eget egestas tellus. Nunc ut velit gravida nisl fringilla rutrum eget at arcu. Vivamus et pretium mauris.

	14 </div>

	15 <script>

	16 if (window.testRunner)

	17 testRunner.waitUntilDone();

	18

	19 setTimeout(function() {
	pdr. 2014/03/24 01:03:18 This test is failing for me locally so I can't con This test is failing for me locally so I can't confirm this, but I suspect this setTimeout(..., 0) can be replaced with forcing a layout using: var forceLayout = document.body.offsetTop timvolodine 2014/03/24 15:24:27 Alternatively, in some tests we use: element = doc Show quoted text On 2014/03/24 01:03:18, pdr wrote: > This test is failing for me locally so I can't confirm this, but I suspect this > setTimeout(..., 0) can be replaced with forcing a layout using: > var forceLayout = document.body.offsetTop Alternatively, in some tests we use: element = document.getElementById("divId"); forceLayout = element.offsetHeight; skobes 2014/03/25 01:23:24 I'm testing that dynamically changing the font sca Show quoted text On 2014/03/24 01:03:18, pdr wrote: > This test is failing for me locally so I can't confirm this, but I suspect this > setTimeout(..., 0) can be replaced with forcing a layout using: > var forceLayout = document.body.offsetTop I'm testing that dynamically changing the font scale factor causes everything to be laid out correctly. If I force a layout it kind of defeats the point of the test.
	20 setFontScaleFactor(2);

	21

	22 if (window.testRunner)

	23 testRunner.notifyDone();

	24 }, 0);

	25

	26 </script>

	27 </body>

	28 </html>

OLD	NEW