milo: source and bot links

milo: source and bot links

- add source and bot links to swarming builds
- render source link
- remove dead code in swarming/build.go
- regen expectations

R=hinoka@chromium.org, estaab@chromium.org
BUG=614404
Committed: https://github.com/luci/luci-go/commit/6dc6eda93d1ef1f154d6849632d8d917e202a62a

[nodir, 2016-06-22 19:00:12]

PTAL
preview:
https://912-d1ceacb-tainted-nodir-dot-luci-milo.appspot.com/swarming/prod/2f8...

[Ryan Tseng, 2016-06-22 19:14:44]

hinoka@google.com changed reviewers:
+ hinoka@google.com

[Ryan Tseng, 2016-06-22 19:14:45]

Buildbot behavior is to make the name of the bot the text for the link.  I also
favor that behavior.

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/fron...
File appengine/cmd/milo/frontend/templates/buildbot/pages/build.html (right):

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/fron...
appengine/cmd/milo/frontend/templates/buildbot/pages/build.html:66: <a href="{{
.Build.Summary.Source.URL }}">{{ .Build.Summary.Source.Label }}</a>
<li> Source:  <a>.....

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/fron...
appengine/cmd/milo/frontend/templates/buildbot/pages/build.html:72: <a href="{{
.Build.Summary.Bot.URL }}">{{ .Build.Summary.Bot.Label }}</a>
<li>Bot: <a.....

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/swar...
File appengine/cmd/milo/swarming/build.go (right):

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/swar...
appengine/cmd/milo/swarming/build.go:196: Label: "swarming task",
Label should be the taskID, or "Task %s"

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/swar...
appengine/cmd/milo/swarming/build.go:241: Label: "swarming bot",
Label should just be the botID

[nodir, 2016-06-22 20:40:08]

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/fron...
File appengine/cmd/milo/frontend/templates/buildbot/pages/build.html (right):

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/fron...
appengine/cmd/milo/frontend/templates/buildbot/pages/build.html:66: <a href="{{
.Build.Summary.Source.URL }}">{{ .Build.Summary.Source.Label }}</a>
On 2016/06/22 19:14:45, Ryan Tseng wrote:
> <li> Source:  <a>.....

Done.

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/fron...
appengine/cmd/milo/frontend/templates/buildbot/pages/build.html:72: <a href="{{
.Build.Summary.Bot.URL }}">{{ .Build.Summary.Bot.Label }}</a>
On 2016/06/22 19:14:45, Ryan Tseng wrote:
> <li>Bot: <a.....

Done.

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/swar...
File appengine/cmd/milo/swarming/build.go (right):

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/swar...
appengine/cmd/milo/swarming/build.go:196: Label: "swarming task",
On 2016/06/22 19:14:45, Ryan Tseng wrote:
> Label should be the taskID, or "Task %s"

Done.

https://codereview.chromium.org/2093503002/diff/20001/appengine/cmd/milo/swar...
appengine/cmd/milo/swarming/build.go:241: Label: "swarming bot",
On 2016/06/22 19:14:45, Ryan Tseng wrote:
> Label should just be the botID

Done.

[Ryan Tseng, 2016-06-22 21:59:55]

lgtm

[nodir, 2016-06-22 22:00:59]

The CQ bit was checked by nodir@chromium.org

[commit-bot: I haz the power, 2016-06-22 22:01:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2093503002/40001

[commit-bot: I haz the power, 2016-06-22 23:12:13]

Description was changed from

==========
milo: source and bot links

- add source and bot links to swarming builds
- render source link
- remove dead code in swarming/build.go
- regen expectations

R=hinoka@chromium.org, estaab@chromium.org
BUG=614404
==========

to

==========
milo: source and bot links

- add source and bot links to swarming builds
- render source link
- remove dead code in swarming/build.go
- regen expectations

R=hinoka@chromium.org, estaab@chromium.org
BUG=614404

Committed:
https://github.com/luci/luci-go/commit/6dc6eda93d1ef1f154d6849632d8d917e202a62a
==========

[commit-bot: I haz the power, 2016-06-22 23:12:14]

Committed patchset #3 (id:40001) as
https://github.com/luci/luci-go/commit/6dc6eda93d1ef1f154d6849632d8d917e202a62a