Move 'response' check in responseReceived() to the backend.

Move 'response' check in responseReceived() to the backend.

Removed the response parameter check in responseRequest() and moved
it to the backend. This resolves a FIXME.
Also removed the existance check in _updateNetworkRequestWithResponse
because only the responseRequest() calls it.

R=pfeldman, vsevik
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171058

[eustas, 2014-03-24 12:52:33]

Overall looks good, but:

1) method name doesn't correspond to its purpose. I'd recommend isResponseEmpty
or isResponseNullOrEmpty

2) this front-end FIXME is tightly bound to another FIXME; take a look at
willSendRequest - it calls responseReceived in case of redirect...

[rtakacs, 2014-03-24 16:15:58]

On 2014/03/24 12:52:33, eustas wrote:
> 2) this front-end FIXME is tightly bound to another FIXME; take a look at
> willSendRequest - it calls responseReceived in case of redirect...

I already have a patch for the other FIXME
(https://gist.github.com/rtakacs/f7c7e9f28a9035afa51b).
Should I merge it with this one?

[eustas, 2014-03-25 07:58:37]

On 2014/03/24 16:15:58, rtakacs.u-szeged wrote:
> On 2014/03/24 12:52:33, eustas wrote:
> > 2) this front-end FIXME is tightly bound to another FIXME; take a look at
> > willSendRequest - it calls responseReceived in case of redirect...
> 
> I already have a patch for the other FIXME
> (https://gist.github.com/rtakacs/f7c7e9f28a9035afa51b).
> Should I merge it with this one?

This would be great.

[eustas, 2014-03-26 05:29:39]

lgtm

[eustas, 2014-03-26 05:30:51]

OWNER's lgtm is still required.

[vsevik, 2014-04-07 12:56:26]

Do you still plan to merge another FIXME fix here?

[vsevik, 2014-04-07 14:43:35]

lgtm

[commit-bot: I haz the power, 2014-04-07 14:43:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/2...

[commit-bot: I haz the power, 2014-04-07 15:04:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-07 15:04:30]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[rtakacs, 2014-04-08 13:19:21]

On 2014/04/07 12:56:26, vsevik wrote:
> Do you still plan to merge another FIXME fix here?

No, I don't.
The other FIXME requires further changes in the public part of protocol that
couldn't be done in current protocol version.

[rtakacs, 2014-04-08 14:04:27]

The CQ bit was checked by rtakacs.u-szeged@partner.samsung.com

[commit-bot: I haz the power, 2014-04-08 14:04:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rtakacs.u-szeged@partner.samsung.com/2...

[commit-bot: I haz the power, 2014-04-08 14:04:51]

Change committed as 171058